Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code in vignettes #17

Open
malcolmbarrett opened this issue Nov 11, 2024 · 0 comments
Open

Code in vignettes #17

malcolmbarrett opened this issue Nov 11, 2024 · 0 comments
Assignees

Comments

@malcolmbarrett
Copy link
Contributor

Unnecessary code

data(iris)
head(iris)

It's unnecessary to use data().

At the end of the file, there is a trailing

```

Which does not match anything

Bugs

results$data$isig is logical. This doesn't correctly test that its value is TRUE

significant_results <- subset(results$data, isig == TRUE)

It should be either

significant_results <- subset(results$data, isig)

or, more robustly,

significant_results <- subset(results$data, isTRUE(isig))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants