Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to Meilisearch v1.13.0 #314

Open
4 of 52 tasks
curquiza opened this issue Jan 22, 2025 · 5 comments
Open
4 of 52 tasks

Changes related to Meilisearch v1.13.0 #314

curquiza opened this issue Jan 22, 2025 · 5 comments
Assignees
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

curquiza commented Jan 22, 2025

This issue gathers the changes related to the v1.13.0 of Meilisearch that will impact the integrations scope.

📅 Release date: 17th February

Timelines & steps

Pre-release

  • With the help of the changelog & this CI, define which integrations should be updated and how (New feature? Update README? Update tests?)
    • Fill in the "What to implement?" section below in this issue 👇. Minial implementation: PHP, JS, meilisearch-js-plugins.
    • Open implementation issues in repositories that need implementation if necessary for developers who will work on the tasks
    • Discuss with the Product team if needed. At least share this issue to let them know about the decisions.
  • Create a branch by running Octopus script: only open branches for the integrations we choose to update (defined in the previous step) + Kubernetes repository + Cloud provider repository (changing the version)
  • Open issues post-release for stabilization of AI
  • Update integrations according to the decisions (cf "What to implement?" section below in this issue 👇)
    ⚠️ If possible, this step is done before pre-release, once the feature is ready thanks to the prototype released by the engine team
    • JS
    • PHP
    • Dart
    • Go
    • Java
    • Python
    • Ruby
    • Rust
  • Add code samples for the chosen up-to-date integrations with the new version of Meilisearch
  • Update the library version of the related integrations and prepare the changelogs

Release day

  • Release the integrations or only merge the related PRs (sometimes a release is not needed)
    • JS
    • PHP
    • meilisearch-js-plugins (at least update meilisearch-js version)
    • Dart
    • Go
    • Java
    • Python
    • Ruby
    • Rust
  • Merge the related PR in K8s repository
  • Publish DevOps tools:
    • create the git tag
    • publish images (steps are in CONTRIBUTING.md)
  • Remove useless AWS images (by using our internal script)
  • Open issues in the repositories that are not up-to-date with the latest version of Meilisearch (including code samples)

Post-release

  • Update the following SDKs with the missing capabilities for AI search
    • Dart: TBD
    • Go: TBD
    • Java: TBD
    • Python: TBD
    • Ruby: TBD
    • Rust: TBD
  • Open issues in Swift and Dotnet for the missing AI capabilities

What to implement?

AI stabilization

Related issue in the engine: meilisearch/meilisearch#4733

Usage: https://meilisearch.notion.site/v1-13-AI-search-changes-17a4b06b651f80538b65d31724545def

  • removal of the vectorStore experimental feature
  • new error codes

TODO:

  • JS: remove vectorStore exp feature + fix tests
  • PHP: remove vectorStore exp feature + fix tests
  • Dart: why test does not break? + remove vectorStore exp feature
  • Go: remove vectorStore exp feature
  • Java: remove vectorStore exp feature
  • Python: remove vectorStore exp feature
  • Ruby: remove vectorStore exp feature
  • Rust: remove vectorStore exp feature

Postponed to v1.14.0
### Granular filterable attributes

Related issue in the engine: meilisearch/meilisearch#5163

Usage: https://meilisearch.notion.site/API-usage-Settings-to-opt-out-indexing-features-filterableAttributes-1764b06b651f80aba8bdf359b2df3ca8?pvs=74

  • accept the new formal of filterable attributes (the old one is still allowed)

TODO:

  • JS: adapt code base + fix tests
  • [ ] PHP: adapt code base + fix tests

Proxy search requests (exp)

Related issue in the engine: meilisearch/meilisearch#4980

Usage: https://meilisearch.notion.site/API-usage-Remote-search-request-f64fae093abf409e9434c9b9c8fab6f3

  • New remote route
  • accept remote search parameter in /multi-search route

TODO:

  • JS: adapt code base + fix tests
  • PHP: adapt code base + fix tests
@ellnix
Copy link

ellnix commented Jan 22, 2025

Granular filterable attributes
Related issue in the engine: meilisearch/meilisearch#5163
Usage: https://meilisearch.notion.site/Opt-out-settings-v2-usage-15c4b06b651f8188ae57fca7aa73b527

accept the new formal of filterable attributes (the old one is still allowed)

@curquiza I don't think that notion link is correct.

@curquiza
Copy link
Member Author

Thank you, I changed

@curquiza
Copy link
Member Author

curquiza commented Jan 23, 2025

@Strift, the Granular filterable attributes feature will not be ready for v1.13.0, but will be done in v1.14.0
Just got the new from engine team, who had difficulties managing the flood of bugs and the sprint lately

@CommanderStorm
Copy link

CommanderStorm commented Jan 24, 2025

How do we want to go about the rust integration?
(I have not updated my PR to remove the experimental part, but can do so)

Kontext:

These are the options

  • remove ExperimentalFeatures::set_vector_store
  • mark ExperimentalFeatures::set_vector_store as deprecated and change to a no-op

And about reviewability:

  • include in the same PR
  • make a new PR

@ellnix
Copy link

ellnix commented Jan 24, 2025

There seems to be precedent for this @CommanderStorm

meilisearch/meilisearch-rust@d12b21b

meilisearch/meilisearch-rust#544

Looks like it was just removed (I suppose it was "experimental" after all). You know better though, of course doing something different could be appropriate in your case. Just thought I'd share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Development

No branches or pull requests

5 participants