Long error messages in flash-error may occlude navbar links

[gjp]

flash-error screenshot

The flash-error div remains part of the layout after the animation has finished. Long error messages, such as authorization errors, may prevent links from being clicked even when the div is invisible.

[ptn]

Currently, error messages fading out are done with CSS keyframe animations. We could replace them with jQuery's fadeOut, which takes a callback that would remove the div.

How about it?

[jordanbyron]

@ptn I think we need to really adress the underlying design problem that the flash div can potentially become larger than the area available to it. Once we do that then this won't be a problem.

[ptn]

@jordanbyron Ah, of course.

The simplest and most direct solution I can think of is showing the flash in between #nav and #container; I'd also make it a bit more visible, i.e. bigger font and centered. I can submit a pull request tonight if all this doesn't sound too terrible.

[jordanbyron]

Go for it Pablo. Could you also send over a screenshot of the new flash message style so I can quickly give you feedback?

ProTip™ when working with flash messages, it helps to disable the automatic hiding so you can get the style just right.