Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15/Material 15 support #126

Open
mattytommo opened this issue Nov 23, 2022 · 14 comments · May be fixed by #128
Open

Angular 15/Material 15 support #126

mattytommo opened this issue Nov 23, 2022 · 14 comments · May be fixed by #128

Comments

@mattytommo
Copy link

Could we possibly get Angular 15 & Material 15 support? This is the only package I have that doesn't support 15, so would be good to get it upgraded :).

@benceHornyak benceHornyak linked a pull request Nov 30, 2022 that will close this issue
@rakia
Copy link

rakia commented Jan 4, 2023

We're also using den --legacy-peer-deps in our project because ngx-material-file-input is still lacking support for Angular 15.
We can't wait for the upgrade.

@Paci3491
Copy link

Paci3491 commented Mar 5, 2023

Yes please, this would be highly appreciated

@APOSWE
Copy link

APOSWE commented Mar 9, 2023

hey! would be great to upgrade!

@mamay12
Copy link

mamay12 commented Mar 20, 2023

any information when it will be updated? i can try to create PR if it needed, but i saw another PR that was rejected as i can see

@Elvynia
Copy link

Elvynia commented Apr 10, 2023

Hope the PR with legacy material implementation could be accepted soon. Really looking forward on angular 15 support !
Thanks for the great work on this project.

@dnordahl1
Copy link

dnordahl1 commented May 1, 2023

Can someone explain why this is a difficult change to make, so we can understand why these major version releases of angular / material take so long to be applied?

@Elvynia
Copy link

Elvynia commented May 2, 2023

@dnordahl1 Read angular migration guides to know what changes with new versions: Update Angular to v15 on Material components

Many of the components in Angular Material v15 have been refactored to be based on Angular Material Design Components (MDC) for the Web. The refactored components offer improved accessibility and adherence to the Material Design spec.

For more information about the updated components, see Migrating to MDC-based Angular Material Components

@dnordahl1
Copy link

dnordahl1 commented May 2, 2023

@Elvynia After getting through the Angular 15 package update challenges, I now see how the MDC-based redesign and deprecation of nearly all existing material components creates major challenges to say the least.

@D4nyi
Copy link

D4nyi commented May 4, 2023

Angular 15 has been released mid november last year, what more, the current version of Angular is 16 (just got released), but the package still does not support v15.
When will this issue will be solved?

@yakeer
Copy link

yakeer commented May 11, 2023

Is this package no longer maintained?

@franbueno
Copy link

franbueno commented Jun 15, 2023

Hey guys! I forked this repo and implemented a quick fix here

Apologies to the main contributors to this project, but I needed to fix it as I used this library in my own project.

Please let me know if my fix is sufficient to create a pull request here so that I'd remove my fork.

Thanks!

P.S.: Thanks, benceHornyak! You had practically solved it, I just gave it the final push :)

@rakia
Copy link

rakia commented Jun 16, 2023

In our project, I get rid of the --legacy-peer-deps flag after replacing this library with an own implemented file-upload component.

It's an Angular custom form-field that does the same as this library & it works with Angular 15 and Angular 16.

You can find it in my repo here. Feel free to use it in your project :)

@leogouveia
Copy link

Hey guys! I forked this repo and implemented a quick fix here

Apologies to the main contributors to this project, but I needed to fix it as I used this library in my own project.

Please let me know if my fix is sufficient to create a pull request here so that I'd remove my fork.

Thanks!

P.S.: Thanks, benceHornyak! You had practically solved it, I just gave it the final push :)

Cool.
Do you think about publishing this fork on npm registry?

@daemons88
Copy link

I just published the package in the Angular 15 version:

  • Npm, (npm i ngx-custom-material-file-input)
  • Repo

Remember to change the references in the project to use the new ones:
ngx-custom-material-file-input, here in the demo project you have an example.

I have tested it only in the library's demo project, for now just note that the placeholder no longer works and a mat-label must be used.

If you find any problem, tell me or raise an issue in the new repo and we will review it together :D
(Just to clarify, I am not an expert in the library but given the need I created this new package to use.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.