Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase number of enabled golangci-lint linters #752

Open
tuminoid opened this issue Nov 21, 2024 · 1 comment
Open

Increase number of enabled golangci-lint linters #752

tuminoid opened this issue Nov 21, 2024 · 1 comment
Labels
kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Nov 21, 2024 •
edited
Loading

IPAM has only 30+ linters enabled in our config whitelist, while CAPM3 has 40+ enabled.

In general, golangci-lint has 100+ linters. Enable more linters at least to match CAPM3.

/kind ci
@metal3-io-bot metal3-io-bot added kind/ci Categorizes issue or PR as related to CI or testing. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 21, 2024
@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted
Let's propose new linters under a github discussion.
This repo is 10 linters behind BMO and CPM3 so at least those 10 should be enabled right away.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tuminoid @Rozzii @metal3-io-bot