Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in loading a saved state #23

Open
michaelpalumbo opened this issue Feb 10, 2022 · 3 comments
Open

error in loading a saved state #23

michaelpalumbo opened this issue Feb 10, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@michaelpalumbo
Copy link
Owner

The following error occurs when loading a state I just saved (and after i refreshed the page)

progressions.js:289 error in nextChord fetch:  TypeError: Cannot read properties of null (reading 'type')
    at suggestChord (progressions.js:318)
    at progressions.js:285

This does not result in any chords being populated in drop-down 1 or 2

@michaelpalumbo michaelpalumbo added the bug Something isn't working label Feb 10, 2022
@michaelpalumbo
Copy link
Owner Author

update:

 console.log(chordNumber, degree, name)

// returns:
2 1 '6'

So the name isn't being stored, or perhaps not being accessed from localStorage

@michaelpalumbo
Copy link
Owner Author

Interesting. Something changed between last night's version and now. A save I made last night contains

2 1 'Db major'

Whereas the one this morning is storing the chordname as a number. Will continue debugging.

@wctestbank
Copy link
Collaborator

I think there's some weird handling for chords that get recommended in column 3. It should work when options from the base list get saved.

I will keep on testing how things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants