From 0813e3fa6d122587572253c73a467c2f36369798 Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Tue, 26 Nov 2024 12:01:24 +0100 Subject: [PATCH 1/2] CI: skip PyVista tests on Windows due to segfault --- tests/datasets/test_idtrees.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/datasets/test_idtrees.py b/tests/datasets/test_idtrees.py index 5fd858ac04f..71c2ae1092d 100644 --- a/tests/datasets/test_idtrees.py +++ b/tests/datasets/test_idtrees.py @@ -4,6 +4,7 @@ import glob import os import shutil +import sys from pathlib import Path import matplotlib.pyplot as plt @@ -96,6 +97,7 @@ def test_plot(self, dataset: IDTReeS) -> None: dataset.plot(x, show_titles=False) plt.close() + @pytest.mark.skipif(sys.platform == 'win32', reason='PyVista segfault on Windows') def test_plot_las(self, dataset: IDTReeS) -> None: pyvista = pytest.importorskip('pyvista', minversion='0.34.2') pyvista.OFF_SCREEN = True From f3899728a4e207a20f75154c360459a70bd173ba Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Tue, 26 Nov 2024 13:04:43 +0100 Subject: [PATCH 2/2] Skip minimum version tests of pyvista too --- requirements/min-reqs.old | 1 - 1 file changed, 1 deletion(-) diff --git a/requirements/min-reqs.old b/requirements/min-reqs.old index c5a5f6dae58..e1058142ac6 100644 --- a/requirements/min-reqs.old +++ b/requirements/min-reqs.old @@ -27,7 +27,6 @@ laspy==2.0.0 opencv-python==4.5.4.58 pycocotools==2.0.7 pyarrow==15.0.0 # Remove when we upgrade min version of pandas to `pandas[parquet]>=2` -pyvista==0.34.2 scikit-image==0.19.0 scipy==1.7.2