Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request does not run tests as check step #16

Open
mikkotikkanen opened this issue May 21, 2020 · 3 comments
Open

Pull request does not run tests as check step #16

mikkotikkanen opened this issue May 21, 2020 · 3 comments

Comments

@mikkotikkanen
Copy link
Owner

The pull request are only running semantic pull request checks and not npm tests

image

npm-test workflow is missing pull request from events

# Trigger the workflow on push or pull request
on: [push, pull_request]

https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-using-a-list-of-events

@mikkotikkanen
Copy link
Owner Author

Fixed after #18 automation update was merged with forcing Test action to be successful in pull request checks

@mikkotikkanen
Copy link
Owner Author

Current solution only works for in-repo pull requests and not for forked repos

@mikkotikkanen
Copy link
Owner Author

image

Now tests are run for pull requests but it's still forcing the in-branch tests to be reported. Probably need to setup two separate workflows so that it can be defined that only pull_request tests are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant