From 8420f20b04b50304ea6465027e0addf0217ce0ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Ramos?= <86117268+nico-ramos@users.noreply.github.com> Date: Thu, 21 Oct 2021 15:49:54 -0300 Subject: [PATCH] Fixed Peerconnection docs (#115) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Paralellized connection to Signaling Websocket and getting and setting local SDP. * Updated eslintignore for local verification. * Updated package lock from packages. * Added parallelize set local description and send publish/view command. Added new setSDPToPeer option for getLocalSDP. It will set the SDP to the peer if it's true (deafult and has the same behaviour as past implementation) * Fix: Stereo flag (#94) * Fix set stereo flag in both opus and multiopus SDP. * Change stereo set order. Now multiopus does not have stereo flag. * Add multisource feature and DTX publish (#92) * add getRTCPeerConnection to BaseWebRTC * add multisource support * add dtx support * add dtx support * do not add transceiver if media is disabled Co-authored-by: Emil Santurio Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Renzo * Updated package version * Change regex when setting Director domain for Safari compatibility. (#96) * Updated SDK version * Add support for abs-capture-time header extension (#98) * Add support for abs-capture-time header extension * Merged develop. Renamed test file to Jest format. Fix unknown replaceAll to replace. * Added linter script to fix syntax. Co-authored-by: Renzo * Updated package version * Add layer events * Refactor event override * Add layer selection * Initial work on projection * first attempt to add dynamic remote tracks * first working version * More readable and understandable variables in viewer-demo README.md (#100) * Release v0.1.12 (#99) * Paralellized connection to Signaling Websocket and getting and setting local SDP. * Updated eslintignore for local verification. * Updated package lock from packages. * Added parallelize set local description and send publish/view command. Added new setSDPToPeer option for getLocalSDP. It will set the SDP to the peer if it's true (deafult and has the same behaviour as past implementation) * Fix: Stereo flag (#94) * Fix set stereo flag in both opus and multiopus SDP. * Change stereo set order. Now multiopus does not have stereo flag. * Add multisource feature and DTX publish (#92) * add getRTCPeerConnection to BaseWebRTC * add multisource support * add dtx support * add dtx support * do not add transceiver if media is disabled Co-authored-by: Emil Santurio Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Renzo * Updated package version * Change regex when setting Director domain for Safari compatibility. (#96) * Updated SDK version * Add support for abs-capture-time header extension (#98) * Add support for abs-capture-time header extension * Merged develop. Renamed test file to Jest format. Fix unknown replaceAll to replace. * Added linter script to fix syntax. Co-authored-by: Renzo * Updated package version Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * More readable and understandable variables Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * More readable and understandable variables in publisher-demo README.md (#101) * Release v0.1.12 (#99) * Paralellized connection to Signaling Websocket and getting and setting local SDP. * Updated eslintignore for local verification. * Updated package lock from packages. * Added parallelize set local description and send publish/view command. Added new setSDPToPeer option for getLocalSDP. It will set the SDP to the peer if it's true (deafult and has the same behaviour as past implementation) * Fix: Stereo flag (#94) * Fix set stereo flag in both opus and multiopus SDP. * Change stereo set order. Now multiopus does not have stereo flag. * Add multisource feature and DTX publish (#92) * add getRTCPeerConnection to BaseWebRTC * add multisource support * add dtx support * add dtx support * do not add transceiver if media is disabled Co-authored-by: Emil Santurio Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Renzo * Updated package version * Change regex when setting Director domain for Safari compatibility. (#96) * Updated SDK version * Add support for abs-capture-time header extension (#98) * Add support for abs-capture-time header extension * Merged develop. Renamed test file to Jest format. Fix unknown replaceAll to replace. * Added linter script to fix syntax. Co-authored-by: Renzo * Updated package version Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * More readable and understandable variables in README.md Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * Added Dictionary options object in signaling publish and subscribe (#106) * add layer to view command and check validity of mapping in projection * Added av1 support (#107) * Release v0.1.12 (#99) * Paralellized connection to Signaling Websocket and getting and setting local SDP. * Updated eslintignore for local verification. * Updated package lock from packages. * Added parallelize set local description and send publish/view command. Added new setSDPToPeer option for getLocalSDP. It will set the SDP to the peer if it's true (deafult and has the same behaviour as past implementation) * Fix: Stereo flag (#94) * Fix set stereo flag in both opus and multiopus SDP. * Change stereo set order. Now multiopus does not have stereo flag. * Add multisource feature and DTX publish (#92) * add getRTCPeerConnection to BaseWebRTC * add multisource support * add dtx support * add dtx support * do not add transceiver if media is disabled Co-authored-by: Emil Santurio Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Renzo * Updated package version * Change regex when setting Director domain for Safari compatibility. (#96) * Updated SDK version * Add support for abs-capture-time header extension (#98) * Add support for abs-capture-time header extension * Merged develop. Renamed test file to Jest format. Fix unknown replaceAll to replace. * Added linter script to fix syntax. Co-authored-by: Renzo * Updated package version Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * Added support to AV1 coedec * Fixed some vulnerability packages Added rollup plugin to support newest Axios version * Comments refactor and change if to one line if Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio Co-authored-by: Renzo * Fix layer selection cmd data * Firefox bitrate support is done inside semantic-sdp now (#109) * Release v0.1.12 (#99) * Paralellized connection to Signaling Websocket and getting and setting local SDP. * Updated eslintignore for local verification. * Updated package lock from packages. * Added parallelize set local description and send publish/view command. Added new setSDPToPeer option for getLocalSDP. It will set the SDP to the peer if it's true (deafult and has the same behaviour as past implementation) * Fix: Stereo flag (#94) * Fix set stereo flag in both opus and multiopus SDP. * Change stereo set order. Now multiopus does not have stereo flag. * Add multisource feature and DTX publish (#92) * add getRTCPeerConnection to BaseWebRTC * add multisource support * add dtx support * add dtx support * do not add transceiver if media is disabled Co-authored-by: Emil Santurio Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Renzo * Updated package version * Change regex when setting Director domain for Safari compatibility. (#96) * Updated SDK version * Add support for abs-capture-time header extension (#98) * Add support for abs-capture-time header extension * Merged develop. Renamed test file to Jest format. Fix unknown replaceAll to replace. * Added linter script to fix syntax. Co-authored-by: Renzo * Updated package version Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio * Firefox bitrate support is done inside semantic-sdp now * update semantic sdp * update semantic-sdp * Removed semantic-sdp from main package.json. Removed unused var browserData Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Emil Santurio Co-authored-by: Renzo * Updated package version * Fixed peerconnection docs Co-authored-by: Renzo Delfino Co-authored-by: Renzo Delfino <75499398+R-Delfino95@users.noreply.github.com> Co-authored-by: Sergio Garcia Murillo Co-authored-by: Emil Santurio Co-authored-by: ctoppel Co-authored-by: Sebastián Piquerez <89274285+sebastianpiq@users.noreply.github.com> --- packages/millicast-sdk/src/PeerConnection.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/millicast-sdk/src/PeerConnection.js b/packages/millicast-sdk/src/PeerConnection.js index 983443fb..ecce7081 100644 --- a/packages/millicast-sdk/src/PeerConnection.js +++ b/packages/millicast-sdk/src/PeerConnection.js @@ -224,7 +224,7 @@ export default class PeerConnection extends EventEmitter { /** * Add remote receving track. * @param {String} media - Media kind ('audio' | 'video'). - * @return {Array[MediaStream]} streams - Streams the stream will belong to. + * @return {Array} streams - Streams the stream will belong to. */ addRemoteTrack (media, streams) { return this.peer.addTransceiver(media, { direction: 'recvonly', streams }).track