Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite redisplay_internal loop with yascroll #376

Closed
whame opened this issue Jun 26, 2023 · 3 comments
Closed

Infinite redisplay_internal loop with yascroll #376

whame opened this issue Jun 26, 2023 · 3 comments

Comments

@whame
Copy link

whame commented Jun 26, 2023

Running the following with emacs -Q -l test.el

;;; test.el

(add-to-list 'load-path "yascroll")
(add-to-list 'load-path "vertico")

;; Vertico needs this.
(add-to-list 'load-path "compat")

(require 'yascroll)
(require 'vertico)

(global-yascroll-bar-mode t)

(vertico-mode)

;; Any dummy file that would be sufficiently big to show the scroll bar.
(find-file "/proc/kallsyms")

(split-window-right)

(call-interactively 'execute-extended-command)

;; Now press C-g (`abort-minibuffers`). Watch the CPU usage of the process
;; (should be very high). gdb shows that `run_window_change_functions()` is
;; called repeatedly.

seems to cause an infinite calls to redisplay_internal() in Emacs.

I can not trigger this behavior without activating Vertico. Therefore, it seems like there is some interference here between yascroll and Vertico.

Now, it could of course be a bug in yascroll only. Do you have any idea what is going on here? Any pointers would also be helpful!

@minad
Copy link
Owner

minad commented Jun 26, 2023

I am not familiar with Yascroll, so I cannot really tell what is causing this. Considering the side of Vertico, I am not aware of any wrong doing related to scrolling. Vertico should not lead to the creation of scrollbars in the miniwindow, since Vertico resizes the miniwindow according to the content. Maybe Yascroll can be configured to avoid interfering with the miniwindow? If this is not possible, I suggest that you use either Vertico or Yascroll but not both together given the incompatibility.

@minad minad closed this as completed Jun 26, 2023
@minad
Copy link
Owner

minad commented Jun 26, 2023

See also emacsorphanage/yascroll#37 and emacsorphanage/yascroll#42 which are probably related.

@whame
Copy link
Author

whame commented Jun 26, 2023

Yeah, in the other Github issues people are experiencing similar issues (not necessarily together with Vertico). I wonder if it has to do with the overlay creations or something (that could trigger a redisplay?).

This was just a long shot. Thank you for your suggestions. I will try to investigate/debug this further. Vertico is such a great package. I would probably have to sacrifice yascroll :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants