Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Expose metrics in the Prometheus format #5

Open
andrewhowdencom opened this issue Mar 10, 2017 · 2 comments
Open

Feature request: Expose metrics in the Prometheus format #5

andrewhowdencom opened this issue Mar 10, 2017 · 2 comments
Labels
needs-pr The maintainers are not working on this, but will help getting a PR merged.

Comments

@andrewhowdencom
Copy link

This is looks like exactly what I was looking for; I got pointed to it by asyncho. I will spin it up in a cluster later today, but am curious: Would you consider adding Prometheus metrics to the Daemon? Prometheus provide a python library (https://github.com/prometheus/client_python), and Kubernetes supports the prometheus format quite well (https://github.com/google/cadvisor/blob/master/docs/application_metrics.md)

I could also look at doing a PR for this, if it's something that you'd accept / help me with (I don't really know python).

@miracle2k
Copy link
Owner

Sure. I don't really know anything about Prometheus, but I would be happy to accept pull requests, and help as far as I am able.

@andrewhowdencom
Copy link
Author

Loovely. I deployed this in a cluster as a test this morning; I will need to know when it goes wrong / doesn't backup as expected (due to developer derps someowhere). I will try to get time to do this in the coming weeks.

@miracle2k miracle2k added the needs-pr The maintainers are not working on this, but will help getting a PR merged. label Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-pr The maintainers are not working on this, but will help getting a PR merged.
Projects
None yet
Development

No branches or pull requests

2 participants