Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create set of tests for new DB API #25

Open
Rjected opened this issue Jun 21, 2019 · 0 comments
Open

Create set of tests for new DB API #25

Rjected opened this issue Jun 21, 2019 · 0 comments
Labels
good first issue Good for newcomers testing A test-related issue

Comments

@Rjected
Copy link
Collaborator

Rjected commented Jun 21, 2019

Is your feature request related to a problem? Please describe.
Now that the database is refactored into something more logical, it would be useful to create a set of tests for the following APIs:

  • SettlementEngine
  • AuctionEngine
  • LimitEngine
  • AuctionOrderbook
  • LimitOrderbook
  • PuzzleStore
  • DepositStore

Describe the solution you'd like
Each of the APIs are fairly descriptive, so creating tests for the API can serve as a test for all future datastore implementations. Creating inputs / outputs for each call is probably enough, given many of them are designed to have inputs as well as outputs.

Describe alternatives you've considered
The database implementations could also be tested individually, but this would probably be the same amount of work, except more useful.

Additional context
N/A

@Rjected Rjected added good first issue Good for newcomers testing A test-related issue labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing A test-related issue
Projects
None yet
Development

No branches or pull requests

1 participant