-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which Modelica Language version for MSL 4.1.0? #4175
Comments
I see conceptual similarities to #1886 where MSL 3.2.2 was based on Modelica Language 3.2, but the pure/impure semantics was missing/insufficient. It was then (temporarily) fixed by introduction of the vendor neutral annotation |
To me that situation was different.
To me that seems like a worse option:
If we don't want to add mustBeConnected to MSL 4.1.0 I would propose that we don't add anything for this release. Instead we state that 3.6 semantics are used, but no 3.6 features are used (we could rely on the general rule that bug-fixes can be implemented even for earlier versions, but that seems messy). |
Note that figure-annotations added in 3.5 should also be considered - #4094 I see the following possibilities:
I don't see switching to 3.5 as a good option. (And my preference is for only 3.6 annotations, and otherwise 3.6 without anything new; I don't view 3.4 as a good option, and I understand that many view 3.6 as too breaking.) |
As I believe it is hard to find the necessary tools to ensure that only certain parts of 3.6 are used, I propose going for the more pragmatic approach of switching to 3.6 fully, but give tool vendors time to react if new and not yet supported features are being used. This also gives a chance for tool vendors to prioritize adding support for the new features that get used by the MSL, features that could otherwise remain unimplemented for very long if there is no pressure from use in important libraries. In other words, waiting for all tool vendors to say that they fully support 3.6 does not seem like a feasible way forward. |
I like the option:
|
With that decision there is now the chance to add the figure annotation, too. Right? See #4094 for the first idea. |
Known issues (will check if more):
#3947 indicate that the current library is not correct according to Modelica Language 3.4 - basically one should get a diagnostics for some examples; and it doesn't make sense to patch them for 3.4 semantics.
Thus if we want MSL to be correct and be able to detect if
Modelica.Mechanics.Rotational.Components.IdealGear
has enabled and unconnected support-connector we need 3.6 semantics and a new annotation in the library (mustBeConnected).If we skip detecting IdealGear issue we can say that we use 3.6 semantics but the library does not contain 3.6 features.
The text was updated successfully, but these errors were encountered: