Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust tests #4523

Open
HansOlsson opened this issue Jan 21, 2025 · 0 comments
Open

More robust tests #4523

HansOlsson opened this issue Jan 21, 2025 · 0 comments
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined

Comments

@HansOlsson
Copy link
Contributor

Consider: ModelicaTest.Fluid.TestUtilities.Test01RegFun3 as an example.

It contains an assertion that is designed to fail just after the simulation stop-time. I assume there are other similar examples.

In practice that causes some issues:

  • Simulators that run slightly past the stop-time (for various reasons) will get problems.
  • Users cannot run modify the stop-time of the simulation, in order to see that the function is smooth past that.

I don't know exactly how to best change it (there are several possibilities), and it is clearly not important for the release; but I think it would be good to improve it later.

Found when investigating #4522
@HansOlsson HansOlsson added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HansOlsson