Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that /bulktransfers and /bulkquotes are working using external PM4MLs #3119

Closed
26 of 31 tasks
PaulGregoryBaker opened this issue Feb 6, 2023 · 3 comments
Closed
26 of 31 tasks
Assignees
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Feb 6, 2023

Goal:

As a Hub operator
I want to test and make use of the mojaloop bulk SDK enhancements
so that evaluate and use these enhancements

As a Hub operator
I want to test and make use of the the latest enhancements
so that evaluate and use these enhancements

Acceptance Criteria:

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Enable TTK in PM4MLs
  • Test /bulkQuotes and /bulkTransfers using a TTK test collection and response rules
  • Check if SDK Scheme Adaptor: BulkTransfer handler is sending bulk request to from.fspId instead of to.fspId #2891 is resolved - Not resolved, the outbound /bulkTransfers is containing wrong fspiop-destination header
    • Complete the story
  • Standardise TTK rules and config in pm4mls by updating latest versions in pm4ml helm chart
  • Standardise the TTK test collection and add it to IaC pipeline
  • Check the TTK PM4ML bulk test collection from the new IaC pipeline is working [@sri-miriyala ]
  • Test the TTK backend with PM4ML combination [@sri-miriyala ]
  • Test the coreconnector and simulator backend with PM4ML combination [@sri-miriyala ]
  • Add negative tests for /bulkquotes
  • Add negative tests for /bulkTransfers [Inprogress]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed core-dev-squad labels Feb 6, 2023
@PaulGregoryBaker PaulGregoryBaker changed the title Ensure that \bulktransfer and \bulkquote are working external PM4MLs Ensure that \bulktransfer and \bulkquotes are working using external PM4MLs Feb 6, 2023
@PaulGregoryBaker
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @sri-miriyala @vijayg10 @kleyow @mdebarros

@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label Feb 6, 2023
@elnyry-sam-k elnyry-sam-k changed the title Ensure that \bulktransfer and \bulkquotes are working using external PM4MLs Ensure that /bulktransfer and /bulkquotes are working using external PM4MLs Feb 9, 2023
@vijayg10 vijayg10 self-assigned this Feb 10, 2023
@vijayg10
Copy link

ttk_tests.zip

@elnyry-sam-k elnyry-sam-k changed the title Ensure that /bulktransfer and /bulkquotes are working using external PM4MLs Ensure that /bulktransfers and /bulkquotes are working using external PM4MLs Feb 13, 2023
@sri-miriyala
Copy link

Issue related to bulk quotes API response: #3160

@sri-miriyala sri-miriyala self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Development

No branches or pull requests

3 participants