Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6634): pin NPM to 10 when Node version is 18 #745

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jan 7, 2025

Description

Pins NPM to 10 with Node.js 18.

What is changing?

Updates dependency script to ensure the pinning.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6634

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review January 7, 2025 14:57
@nbbeeken nbbeeken self-assigned this Jan 13, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 13, 2025
nbbeeken
nbbeeken previously approved these changes Jan 13, 2025
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some new issue has cropped up in latest. I imagine this would repro on main if we just re-ran the latest task so its external, can you just confirm and capture the issue in a ticket?

Should we skip latest here to keep the CI green?

@durran
Copy link
Member Author

durran commented Jan 14, 2025

LGTM, but some new issue has cropped up in latest. I imagine this would repro on main if we just re-ran the latest task so its external, can you just confirm and capture the issue in a ticket?

Should we skip latest here to keep the CI green?

I confirmed on main and added NODE-6662. I'll skip here when back on Wednesday - we also still need mongodb-labs/drivers-evergreen-tools#573 to go in first so I can remove the direct clone from that branch here as well.

@durran durran requested a review from nbbeeken January 15, 2025 10:38
.evergreen/config.yml Outdated Show resolved Hide resolved
@nbbeeken nbbeeken merged commit eca63c9 into main Jan 15, 2025
8 checks passed
@nbbeeken nbbeeken deleted the pin-npm branch January 15, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants