Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitbook displays draft MIPs as review MIPs #80

Open
apenzk opened this issue Jan 2, 2025 · 2 comments
Open

gitbook displays draft MIPs as review MIPs #80

apenzk opened this issue Jan 2, 2025 · 2 comments
Assignees

Comments

@apenzk
Copy link
Contributor

apenzk commented Jan 2, 2025

Issue

The MIPbook displays the categories Approved and Review. However the category Review contains Drafts as well, e.g. MIP-73, which it should not.

Solution

Adjust the script for the mipbook such that only Review PRs are considered for the Review category, not Drafts.

@franck44
Copy link
Contributor

franck44 commented Jan 5, 2025

@apenzk @vpallegar I cannot see a draft category in the gitbook.
Maybe it is worth having one so we can map the three statuses (draft, review, approved) to the gitbook?

@apenzk
Copy link
Contributor Author

apenzk commented Jan 6, 2025

not so much in favor of Drafts being displayed in the gitbook. Its a very unready stage. While the mipbook is quite outward facing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants