Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework cleanup #109

Closed
wants to merge 1 commit into from
Closed

Framework cleanup #109

wants to merge 1 commit into from

Conversation

andygolay
Copy link

@andygolay andygolay commented Dec 4, 2024

Description

  • Refactor ethereum module into its own ethereum.move file
  • Add ethereum.md doc
  • Name all errors in asserts in native_bridge.move
  • Remove two unused functions in bridge.rs
  • Ensure no Move warnings are present and tests pass

Type of Change

  • New feature
  • [ x] Bug fix
  • Breaking change
  • [ x] Performance improvement
  • [ x] Refactoring
  • Dependency update
  • [ x] Documentation update
  • [ x] Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • [ x] Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

  • Move unit tests (movement move test) and E2E Move tests (cargo test bridge) pass

Checklist

  • [ x] I have read and followed the CONTRIBUTING doc
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • [ x] I have made corresponding changes to the documentation

@andygolay andygolay marked this pull request as ready for review December 4, 2024 03:20
@andygolay
Copy link
Author

Closing in favor of the improvements in #110

@andygolay andygolay closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Refactor ethereum module into its own file, name all native bridge errors, remove unused functions
2 participants