Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync preferences are not saved during account creation on iOS #24296

Open
jonalmeida opened this issue Jan 23, 2025 · 1 comment
Open

Sync preferences are not saved during account creation on iOS #24296

jonalmeida opened this issue Jan 23, 2025 · 1 comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jan 23, 2025

Affected FxA versions:

  • 1.302.1;

Tested Firefox version:

  • 134.1;

OS version:

  • iOS 18.1.1;

Prerequisites:

  • Do not have an fx account created;
  • Do not be connected to Sync;

Steps to reproduce:

  1. Perform the sign up flow from Sync and select 2-3 sync options during creation;
  2. Click on the hamburger menu option;
  3. Click on the option that displays the email address from step 1;
  4. Observe the Sync settings option;

Expected result:

  • The selected options during account creation are on;

Actual result:

  • All the sync options are off;

Additional notes:

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Jan 23, 2025
@jonalmeida
Copy link
Contributor Author

This is an iOS bug - during the first sync the SyncParams.enabledChanges is always empty which leads to the list of ‘Choose what to sync’ options be turned off. Sync is working correctly, it’s the application side that needs to set the correct engines in the first sync. You can follow what Android does here: https://searchfox.org/mozilla-central/rev/4f5426084651871759f5346eb0ded2e9ac5326fd/mobile/android/android-components/components/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/sync/WorkManagerSyncManager.kt#407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

No branches or pull requests

1 participant