Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index 49 is out of bounds for the schedule array, #12

Open
Krek12 opened this issue Sep 27, 2024 · 7 comments
Open

index 49 is out of bounds for the schedule array, #12

Krek12 opened this issue Sep 27, 2024 · 7 comments

Comments

@Krek12
Copy link

Krek12 commented Sep 27, 2024

*** Error executing callback cfg_denoiser_callback for /home/studio-lab-user/asd/extensions/sd-webui-detail-daemon/scripts/detail_daemon.py
Traceback (most recent call last):
File "/home/studio-lab-user/asd/modules/script_callbacks.py", line 333, in cfg_denoiser_callback
c.callback(params)
File "/home/studio-lab-user/asd/extensions/sd-webui-detail-daemon/scripts/detail_daemon.py", line 157, in denoiser_callback
multiplier = self.schedule[idx] * .1
IndexError: index 49 is out of bounds for axis 0 with size 25

@muerrilla
Copy link
Owner

Need more context.

@Krek12
Copy link
Author

Krek12 commented Oct 10, 2024

Need more context.

I basically don't understand it myself, the extension seems to work but every step shows this is what you saw above.

@blepping
Copy link

blepping commented Oct 24, 2024

the logic for detecting 2 step samplers isn't working in this case. the extension makes a schedule with steps * 2 - 1 for those, not so coincidentally 25 * 2 - 1 is 49. you're probably using a sampler with a name it doesn't recognize as requiring that logic.

@muerrilla
Copy link
Owner

muerrilla commented Oct 24, 2024

the logic for detecting 2 step samplers isn't working in this case. the extension makes a schedule with steps * 2 - 1 for those, not so coincidentally 25 * 2 - 1 is 49. you're probably using a sampler with a name it doesn't recognize as requiring that logic.

Half correct: The steps * 2 - 1 thing is done for a few samplers specified by name. So if the sampler name is not recognized it would not be triggered. So this can't be a case of sampler name not being recognized; hence the need for more context.

Oops, my bad. You're absolutely correct, I wasn't paying enough attention to which line is throwing the error. So, this might be caused by the 1.10.0 update. Haven't had time to update yet.

@Krek12 what sampler and webui version are you using?

@blepping
Copy link

@muerrilla not sure if it would be useful to you, but this is how i tried to deal with the problem: https://github.com/Jonseed/ComfyUI-Detail-Daemon/blob/6d89e3326563c3f6418c89ec62294b8169d85cfc/detail_daemon_node.py#L199

in the case where we want to call the model with a sigma in between two of the schedule sigmas, we interpolate between the two DD adjustments proportionately. for example, if the sigma is 10% of the way from the low sigma to the high sigma then you'd get a mix of 90% of the DD schedule at the low sigma and 10% from the high sigma. that's what it's supposed to do anyway, not sure it actually works correctly.

with that approach, you don't have to care about how many steps a sampler uses.

@muerrilla
Copy link
Owner

@muerrilla not sure if it would be useful to you, but this is how i tried to deal with the problem:

Interesting approach, but this is both impossible to pull off feasibly in a1111 (as far as I understand) and also way more complex than my one-line workaround - which only requires regular manual maintenance 😅 to keep the list of 2-step samplers up-to-date.

Cheers.

@Krek12
Copy link
Author

Krek12 commented Oct 27, 2024

the logic for detecting 2 step samplers isn't working in this case. the extension makes a schedule with steps * 2 - 1 for those, not so coincidentally 25 * 2 - 1 is 49. you're probably using a sampler with a name it doesn't recognize as requiring that logic.

Half correct: The steps * 2 - 1 thing is done for a few samplers specified by name. So if the sampler name is not recognized it would not be triggered. So this can't be a case of sampler name not being recognized; hence the need for more context.

Oops, my bad. You're absolutely correct, I wasn't paying enough attention to which line is throwing the error. So, this might be caused by the 1.10.0 update. Haven't had time to update yet.

@Krek12 what sampler and webui version are you using?

AUTOMATIC, sampler DYN

https://github.com/Koishi-Star/Euler-Smea-Dyn-Sampler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants