Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add link to Java Libraries with Hashing Function to README #41

Open
vorburger opened this issue Jan 4, 2025 · 2 comments · May be fixed by #42
Open

docs: Add link to Java Libraries with Hashing Function to README #41

vorburger opened this issue Jan 4, 2025 · 2 comments · May be fixed by #42

Comments

@vorburger
Copy link

vorburger commented Jan 4, 2025 •
edited
Loading

I am using Multihash in (my) dev.enola.common.io.hashbrown.Multihashes class, but so far was only able to "map" 3 of the (many) Type of Multihash to hashing functions of which I actually have a (Java) implementation...

Would it perhaps make sense to have a section in the README listing recommended (other) libraries which support (some of) all these has functions?

I could raise a PR to make a start with the Guava com.google.common.hash mapping, if that would be of interest? Does anyone reading this have pointers to others?

Or... should this perhaps not be "doc", but "code" - would (something like) my utility class be useful in this java-multihash project itself? But then it would depend on other libraries. Or should we create a new repo under multiformats for this?
@ianopolous
Copy link
Member

This is definitely trying not to depend on any hash implementations, as consumers of this library can use different implementations for different reasons. Many users also won't be interested in most of the hash functions.

vorburger added a commit to vorburger/java-multihash that referenced this issue Jan 4, 2025
@vorburger
Add initial list of actual Multihash.Type implementations to README (f…
434e9c4 
…ixes multiformats#41)
@vorburger vorburger linked a pull request Jan 4, 2025 that will close this issue
Open
@vorburger
Copy link
Author

This is definitely trying not to depend on any hash implementations, as consumers of this library can use different implementations for different reasons. Many users also won't be interested in most of the hash functions.

@ianopolous ACK; that makes perfect sense. In that case, how about #42 just as an (initial) doc - merge?

PS: If you or anyone else reading this has pointers to other libraries implementing any of the Multihash functions, contrib. PRs adding them to the README!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial list of actual Multihash.Type implementations to README vorburger/java-multihash
2 participants
@ianopolous @vorburger