You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're saving the SyncKey per ActiveSyncAccount, ActiveSyncCalendar and ActiveSyncAddressbook separately, one for each. Is that correct? Is the sync key for the entire account, or specific for a calendar, address book or email account?
I am still getting #282 , and this could explain it.
Either way, we should probably unify makeSyncRequest() between them anyways, should we not? ActiveSyncCalendar.makeSyncRequest() and ActiveSyncAddressbook.makeSyncRequest() appear to be identical, so they should be shared. Whereas ActiveSync.makeRequest() seems completely different, but I am not sure that it's for a good reason, and it doesn't handle sync status 3 at all.
The text was updated successfully, but these errors were encountered:
Is the sync key for the entire account, or specific for a calendar, address book or email account?
Both. The account has a hierarchy sync key, and each folder (a calendar and an address book counts as a folder, as does each email folder of course) also has its own sync key.
Either way, we should probably unify makeSyncRequest() between them anyways, should we not?
We don't have CRTP in JavaScript, so you can't inherit the function into both classes, so you would have to have a global function which accepts what I currently call an ActiveSyncPingable (since it can be Pinged) and performs a sync request against it, and then the classes have a helper function that delegates to the global function.
makeRequest doesn't make Sync requests, which is probably why it's completely different, and its error code is 9, not 3 (ActiveSyncError.ts has a typo on line 100, because I didn't notice where the gap in the numbering was.)
Did you check your calendar.db in case there were duplicated entries?
We're saving the
SyncKey
perActiveSyncAccount
,ActiveSyncCalendar
andActiveSyncAddressbook
separately, one for each. Is that correct? Is the sync key for the entire account, or specific for a calendar, address book or email account?I am still getting #282 , and this could explain it.
Either way, we should probably unify
makeSyncRequest()
between them anyways, should we not?ActiveSyncCalendar.makeSyncRequest()
andActiveSyncAddressbook.makeSyncRequest()
appear to be identical, so they should be shared. WhereasActiveSync.makeRequest()
seems completely different, but I am not sure that it's for a good reason, and it doesn't handle sync status 3 at all.The text was updated successfully, but these errors were encountered: