Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail: Persons tab creates huge number of server requests #368

Open
benbucksch opened this issue Jan 10, 2025 · 1 comment
Open

Mail: Persons tab creates huge number of server requests #368

benbucksch opened this issue Jan 10, 2025 · 1 comment

Comments

@benbucksch
Copy link
Collaborator

Reproduction

  1. Go to Mail | Vertical view
  2. Select the Persons tab
  3. Select a person
  4. Unselect it
  5. Select one or multiple other persons

Actual result

  • App creates thousands of server requests to the mail server. Happens in IMAP (seen by Nick) and Exchange protocols (seen by Ben many months ago), so it's protocol independent.
  • Server freaks out and blocks the user. Might cause Mail, Sent folder, Invalid credentials (Failure) #350
  • No other user observable problem, other than the app being very slow and erratic

Expected result

  • Only very few network requests
  • No looping
  • No insane (unnecessarily much) processing
benbucksch added a commit that referenced this issue Jan 10, 2025
@benbucksch benbucksch changed the title Mail: Persons tabs creates huge number of server requests Mail: Persons tab creates huge number of server requests Jan 13, 2025
@benbucksch
Copy link
Collaborator Author

benbucksch commented Jan 13, 2025

To add logging:

  • For IMAP, you can add a console.log() in IMAPFolder.runCommand(). Even IMAPEMail.download() etc goes through that. You won't have any info about the command being run, but at least you know that we contact the server.
  • For HTTP requests (e.g. Exchange protocols), you can use backend.ts line 150:
    ```// console.log("Calling server", "input", input, "options", options, "defaults", defaultOptions);` ``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants