Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style of popup if thumbnails are disabled #182

Open
mzur opened this issue Sep 24, 2021 · 4 comments
Open

Fix style of popup if thumbnails are disabled #182

mzur opened this issue Sep 24, 2021 · 4 comments
Labels
gnome-42 help wanted Extra attention is needed

Comments

@mzur
Copy link
Owner

mzur commented Sep 24, 2021

The switcher popup without thumbnails should have the same style/look than the default switcher popup.

@mzur mzur added help wanted Extra attention is needed gnome-40 labels Sep 24, 2021
@ebeem
Copy link
Collaborator

ebeem commented Sep 24, 2021

Is it different? it should be exactly the same now, they use the same code.

@mzur
Copy link
Owner Author

mzur commented Sep 25, 2021

Default switcher:
image

Wsmatrix:
image

@ebeem
Copy link
Collaborator

ebeem commented Dec 16, 2021

oh, this is going to be quite hard.
wsmatrix now extends SwitcherPopup instead of WorkspaceSwitcherPopup
both parents extend St.Widget, but each has its own way of constructing the popup.

I tried to just bring back the style classes from WorkspaceSwitcherPopup but that showed a very bad style and the indicator wasn't even visible.
Maybe we will need to look more into this but I think it's low priority issue. The only thing here is that wsmatrix will get the style from other switchers like the app switcher rather than the workspaces switcher. This actually helped us a lot because theme developers take into account the app switcher which shows icons of the app (similar to thumbnails), but never take into consideration the possibility of thumbnails existing in the WorkspaceSwitcherPopup which caused the usability styling issues we had with some themes.

In case we need to get this back, I suggest we keep trying having one switcher popup class for both with or without thumbnails.

@mzur
Copy link
Owner Author

mzur commented May 1, 2022

GNOME 42 uses a new switcher popup style with dots at the bottom. I'd like to use this style for our popup without thumbnails (if someone is willing to implement it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gnome-42 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants