-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workspace thumbnails box size in overview #177
Comments
I've observed this in Fedora 35 with GNOME 41.1 on Wayland.
While not part of this bug, the workspace grid overview is unexpectedly small and the config offers no opportunity to scale it. |
The ThumbnailsBox base class only uses the x coordinate to test whether a point is in a workspace. This is not sufficient when we may have multiple rows of thumbnails. The new _withinWorkspace function also uses the y coordinate. This requires overriding handleDragOver as well so that it passes both the x and y coordinates to _withinWorkspace. Fixes mzur#177.
I believe I have a fix for this issue at mainland/gnome-shell-wsmatrix@62be78e8. Since the fix is for an older version of gnome-shell (42.9), I didn't open a pull request. |
This was originally implemented by @mainland. The ThumbnailsBox base class only uses the x coordinate to test whether a point is in a workspace. This is not sufficient when we may have multiple rows of thumbnails. The new _withinWorkspace function also uses the y coordinate. This requires overriding handleDragOver as well so that it passes both the x and y coordinates to _withinWorkspace. References mainland@62be78e8 References #177
Thanks @mainland! I've applied your changes in #270 and it works nicely. This issue is also about fixing the behavior when switching workspaces with a click. Would you be willing to look into that, too? I noticed that the switching works if you click on a window in one of the lower workspaces but not if you click on the background. |
The ThumbnailsBox base class only uses the x coordinate to test whether a point is in a workspace. This is not sufficient when we may have multiple rows of thumbnails. The new _withinWorkspace function also uses the y coordinate. This requires overriding handleDragOver as well so that it passes both the x and y coordinates to _withinWorkspace. Fixes mzur#177.
This fix adjusts the ThumbnailsBox's allocation in vfunc_allocate. A better fix would correctly specify the preferred width and height, but I couldn't figure out how to get that to work. This patch finally fully fixes mzur#177.
I believe I have a full fix, updated for Gnome Shell 46, at mainland/gnome-shell-wsmatrix@f63cf909. Drag and drop works on all workspace, and selecting a workspace in any row now works even when clicking on the workspace background. These fixes only work with version 46, so they may not solve, e.g., #270, which appears to be reporting the same issue but for an older version of Gnome Shell. |
Thanks @mainland! I'll look at it as soon as I can and try to finally merge the PR with the fix. Support for older GNOME versions is not an issue. I'm way behind trying to support only the most recent version... |
Or maybe could you please open a PR against #270 to make this a little easier? |
The container box of the workspace thumbnails has the wrong height. This cuts off mouse events for all thumbnails but those in the first row. Effects:
The text was updated successfully, but these errors were encountered: