Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using same PSR distance parameter for multiple CW signals #199

Open
paulthebaker opened this issue May 23, 2019 · 2 comments
Open

using same PSR distance parameter for multiple CW signals #199

paulthebaker opened this issue May 23, 2019 · 2 comments

Comments

@paulthebaker
Copy link
Member

When a user initializes two (or more) CW signals to search simultaneously, each CW carries it's own set of pulsar distance parameters. These parameters should be collected so that all CW's use the same pulsar distance for each pulsar.

To my knowledge, this was discovered by @caitlinawitt during the IPTA MDC2. It will be important for when @bencebecsy incorporates pulsar terms in his N*CW work.

@bencebecsy
Copy link
Contributor

I've just got to including pulsar terms. Thanks for the heads-up.

Shouldn't this be an issue at enterprise_extensions rather than enterprise? At least when I set up multiple CWs, the p_dist and pphase parameters are initiated by some enterprise_extension function (CWSignal, I think).

Note: It's a bit complicated though, because I'm not actually using the main of enterprise_extensions, but my own version due to a separate issue (https://github.com/stevertaylor/enterprise_extensions/issues/12). It looks like the current version of CWSignal in enterprise_extensions (https://github.com/stevertaylor/enterprise_extensions/blob/master/enterprise_extensions/models.py#L901) doesn't even set up pulsar distance and phase at psr parameters. Can maybe @stevertaylor explain why?

With that said, I'd be happy to look into this and come up with a solution, but I would need a fix first for issue #12 at enterprise_extensions.

@paulthebaker
Copy link
Member Author

I think you are correct that the CW code is in enterprise_extensions. There was some discussion about moving it to enterprise base (the GW memory stuff is in enterprise.signals.utils).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants