Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factors of 2pi missing in Likelihood #405

Open
vhaasteren opened this issue Jan 8, 2025 · 0 comments
Open

Factors of 2pi missing in Likelihood #405

vhaasteren opened this issue Jan 8, 2025 · 0 comments

Comments

@vhaasteren
Copy link
Member

In signal_base.py the LogLikelihood class implements the likelihood. This likelihood is not including factors of 2pi that should be there. This does not affect many analyses. However, the fully marginalized likelihood / evidence will miss those factors of 2pi. That means the evidence is incorrect. This difference is quite large, since there is a log(2 pi) contribution for every data point.

This is not a normalization matter, the likelihood is normalized with respect to the data. All those factors of 2pi need to be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant