Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperModel get_lnlikelihood and get_lnprior slower than necessary #200

Open
AaronDJohnson opened this issue Dec 20, 2022 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AaronDJohnson
Copy link
Collaborator

Each of get_lnlikelihood and get_lnprior have a for loop in the HyperModel class to get the relevant parameters for the selected model. This leads to these methods taking much longer than necessary. The parameter indices do not change, and they should instead be decided in __init__. This can be stored in a dict (for example) and called quickly without a for loop.

@AaronDJohnson AaronDJohnson added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant