Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disallow mouse events when in compact mode for plots #7975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't disallow mouse events when in compact mode for plots #7975

wants to merge 2 commits into from

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jan 6, 2025 •
edited
Loading

Closes #7968 #7969

Describe your changes:

Allow highlights and locking highlight points for plots in compact mode.
Cursor guides and grid lines for stacked plots also fixed.
Synchronized cursor guides and grid lines in compact mode will be done in #7960.
Still disallow pan and zoom in compact mode - this will be handled in #7958.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (5be103e) to head (5433113).

Files with missing lines Patch % Lines
src/plugins/plot/MctPlot.vue 56.25% 3 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7975      +/-   ##
==========================================
- Coverage   57.70%   57.28%   -0.42%     
==========================================
  Files         678      678              
  Lines       27428    27426       -2     
  Branches     2691     2692       +1     
==========================================
- Hits        15826    15711     -115     
- Misses      11264    11372     +108     
- Partials      338      343       +5
Flag Coverage Δ
e2e-ci 62.82% <ø> (+<0.01%) ⬆️
e2e-full 23.65% <ø> (-18.36%) ⬇️
unit 49.34% <56.25%> (-0.18%) ⬇️
Files with missing lines Coverage Δ
src/plugins/plot/PlotView.vue 72.00% <ø> (+2.76%) ⬆️
src/plugins/plot/MctPlot.vue 37.06% <56.25%> (-0.14%) ⬇️

... and 17 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...5433113. Read the comment docs.

@shefalijoshi shefalijoshi requested review from akhenry and removed request for akhenry January 6, 2025 19:21
@scottbell
Copy link
Contributor

Testing by itself:

Screen.Recording.2025-01-07.at.11.16.54.mov

and with the discrete event visualization:

Screen.Recording.2025-01-07.at.11.17.52.mov

it works well! I'll leave it to @unlikelyzero as to whether we need a test, but the code is looking good.

@scottbell scottbell self-requested a review January 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbell scottbell scottbell approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot legends in Time Strip don't show values on hover
2 participants
@shefalijoshi @scottbell