Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filterable create #7978

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Filterable create #7978

wants to merge 13 commits into from
+182 −67

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Jan 6, 2025 •
edited
Loading

Closes #7977

Describe your changes:

Added some nice to have functionality, such as:

  • filterable create menu (by item name)
  • if create menu filtered to one item, Enter will simulate a click
  • create menu able to be closed with Escape
  • overlay dialog with buttons, Enter and Escape will simulate "Ok" and "Cancel"
  • Properties form (create/edit properties), Enter and Escape will simulate "Ok" and "Cancel"
  • Time popups (realtime/fixed) added Enter and Escape to simulate the ✅ and ❎

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.97%. Comparing base (5be103e) to head (2cf5e73).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7978      +/-   ##
==========================================
+ Coverage   57.70%   61.97%   +4.27%     
==========================================
  Files         678      436     -242     
  Lines       27428    13642   -13786     
  Branches     2691        0    -2691     
==========================================
- Hits        15826     8455    -7371     
+ Misses      11264     5187    -6077     
+ Partials      338        0     -338
Flag Coverage Δ
e2e-ci 61.88% <ø> (-0.94%) ⬇️
e2e-full 47.08% <ø> (+5.07%) ⬆️
unit ?
Files with missing lines Coverage Δ
src/api/menu/menu.js 96.55% <ø> (ø)

... and 379 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...2cf5e73. Read the comment docs.

jvigliotta and others added 2 commits January 7, 2025 13:37
@jvigliotta
cleanup remove debug code
8dff9f1
@charlesh88
Sanding and shimming in CSS related to Create menu
9309366 
- Create menu labels can now wrap.
- Line height, padding adjusted for menu items.
- Create menu filter input slimmed down a bit.
charlesh88
charlesh88 requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting mostly on UI-related aspects:

  1. Filtering in the Create menu is operating on both the object name and the description. For example, enter filter by "row" and note that you'll see 4 objects, none of which have that string in their names. This should not use the description field and only filter by name.
  2. Now that we've done Enter and Esc keys in dialogs, the Time Conductor popup also expects the love. Currently, the Enter key only works if the user's cursor is within a numeric input, and Esc doesn't do anything. Can we make this consistent with the dialogs?

@charlesh88
Copy link
Contributor

Looks really good, and love the quality of life improvements. Pushed a few small tweaks:

  • Create menu labels can now wrap.
  • Line height, padding adjusted for menu items.
  • Create menu filter input slimmed down a bit.

image

@jvigliotta jvigliotta marked this pull request as ready for review January 9, 2025 18:56
@jvigliotta jvigliotta requested a review from charlesh88 January 9, 2025 18:56
charlesh88
charlesh88 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, smoke tested and all looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesh88 charlesh88 charlesh88 approved these changes

@shefalijoshi shefalijoshi Awaiting requested review from shefalijoshi

Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filterable create menu and key listeners for forms
2 participants
@jvigliotta @charlesh88