From cd75bfb4d55bbedbd33f3b541eff35effec44a66 Mon Sep 17 00:00:00 2001 From: Karsten Dambekalns Date: Tue, 19 Nov 2024 16:49:55 +0100 Subject: [PATCH] TASK: Drop `runBare()` override from `StandaloneViewTest` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As of PHPUnit 11 `runBare()` is a `final` method. This was written ages ago by Sebastian Kurfürst, who recently said: > IMHO we wanted to run each test twice to run it without cache and > then with cache. But it seems this was broken anyways since a long > time – so we can drop it --- .../Tests/Functional/View/StandaloneViewTest.php | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php b/Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php index 7f3a7fb781..2be96a13af 100644 --- a/Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php +++ b/Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php @@ -30,21 +30,6 @@ class StandaloneViewTest extends FunctionalTestCase */ protected $standaloneViewNonce = '42'; - /** - * Every testcase should run *twice*. First, it is run in *uncached* way, second, - * it is run *cached*. To make sure that the first run is always uncached, the - * $standaloneViewNonce is initialized to some random value which is used inside - * an overridden version of StandaloneView::createIdentifierForFile. - */ - public function runBare(): void - { - $this->standaloneViewNonce = uniqid('', true); - parent::runBare(); - $numberOfAssertions = $this->getNumAssertions(); - parent::runBare(); - $this->addToAssertionCount($numberOfAssertions); - } - /** * @test */