New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive uploading should use streaming uploads #1752

Open

joshk opened this issue Jan 11, 2025 · 0 comments

Collaborator

joshk commented Jan 11, 2025

Archive uploads currently uses:

bucket()
|> S3.put_object(key, File.read!(file_path), Keyword.get(opts, :meta, []))
|> ExAws.request!()

which reads the full file into memory, and passes it into S3.put_object/3

We should change this to match what we do for firmware uploading where we stream the file to ExAWS.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment