Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: safari login redirect leads to invalid request #599

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: safari login redirect leads to invalid request #599

wants to merge 9 commits into from

Conversation

JasperVandenberghen
Copy link
Contributor

@JasperVandenberghen JasperVandenberghen commented Apr 8, 2022 •
edited
Loading

No description provided.

@JasperVandenberghen JasperVandenberghen self-assigned this Apr 8, 2022
@JasperVandenberghen JasperVandenberghen added bug Something isn't working dependencies labels Apr 8, 2022
@JasperVandenberghen JasperVandenberghen linked an issue Apr 8, 2022 that may be closed by this pull request
Login fails with Safari #554
Open
@JasperVandenberghen JasperVandenberghen marked this pull request as ready for review April 15, 2022 13:36
@lem-onade lem-onade changed the title fix: safari-bug-fix fix: safari login redirect leads to invalid request Apr 15, 2022
@JasperVandenberghen JasperVandenberghen mentioned this pull request Apr 15, 2022
Open
@lem-onade lem-onade changed the base branch from develop to master April 28, 2022 11:00
lem-onade
lem-onade requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to update the proxy-config.json file as well to fix the deployed version. local-config.json is only used when running locally as the name suggests.

@JasperVandenberghen
Copy link
Contributor Author

you'll have to update the proxy-config.json file as well to fix the deployed version. local-config.json is only used when running locally as the name suggests.

Oh sorry, did not realise I forgot that one.

@JasperVandenberghen JasperVandenberghen enabled auto-merge (squash) May 19, 2022 11:44
auto-merge was automatically disabled April 4, 2023 14:35

Merge could not be authorized

@lem-onade lem-onade removed their request for review July 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lem-onade lem-onade lem-onade requested changes

@AbelVandenBriel AbelVandenBriel Awaiting requested review from AbelVandenBriel

@BelgianNoise BelgianNoise Awaiting requested review from BelgianNoise

Requested changes must be addressed to merge this pull request.

Assignees

@JasperVandenberghen JasperVandenberghen

Labels
bug Something isn't working dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login fails with Safari
2 participants
@JasperVandenberghen @lem-onade