Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event details design improvements #3543

Closed
ChristophWurst opened this issue Oct 12, 2021 · 13 comments · Fixed by #5675
Closed

Event details design improvements #3543

ChristophWurst opened this issue Oct 12, 2021 · 13 comments · Fixed by #5675
Assignees
Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@ChristophWurst
Copy link
Member

Right now event details are filled in and edited via a tabbed sidebar. We could move this view into a modal and benefit from more vertical space. That space will allow us to render the free/busy view right away right below attendees and rooms.

Design-wise this modal could looks similar to the setting modals. What is a tab right now can be a settings section.

@jancborchardt @nimishavijay for the actual design specs, I'm just brainstorming :)

Required for #3418

@ChristophWurst ChristophWurst added enhancement-proposed 0. to triage Pending approval or rejection design Related to design, interface, interaction design, UX, etc. labels Oct 12, 2021
@nimishavijay
Copy link
Member

This is a great idea for space and organising the different sections, but I am also worried a bit about being able to browse through the calendar while viewing/editing event details. Outlook does it like as a modal, and to allow you to see the other events there's a smaller view on the right. IMHO it looks a bit clunky.

image

@jancborchardt and I were thinking about a sidebar without tabs, and all the details arranged one below the other with scrolling. We can also maybe think about removing the illustration on top for more vertical space.
New sidebar mockups are actually in progress, but what do you think about the idea?

@ChristophWurst
Copy link
Member Author

First of all I have to admit I once again mixed vertical and horizontal space 🙈

The sidebar is limited in its width. We won't be able to cram the free/busy view into this. So even without the tabs or illustrations the width won't be sufficient. Attendee names alone can easily take half of the sidebar's width, and then you need to still show a full grid with the availability. That seems impossible to fit in there.

I am also worried a bit about being able to browse through the calendar while viewing/editing event details

That is a good point and indeed the modal would prevent this.

@jancborchardt jancborchardt changed the title Move event details from sidebar to a modal Event details design improvements Oct 13, 2021
@nimishavijay
Copy link
Member

nimishavijay commented Oct 13, 2021

So @jancborchardt and I were discussing this, and we thought a modal wouldn't allow you to browse through the calendar while seeing the details so a sidebar would be a better option. Free/busy is kind of a more advanced(ish) feature that people wouldn't NEED to see all the time, so a couple of extra clicks is okay.

We were working on an updated design for both the card and sidebar, though. What do you think?

Card Sidebar
image image

More screenshots and details

Adding guests (card view)
image

Adding a video call link
image

Adding a reminder
image

  • The buttons in card view would be:

    • New event: Create event & Cancel
    • Edit existing single event: Save, More options (which opens the sidebar)
    • Edit existing recurring event: Save, More options (which opens the sidebar)
  • The buttons in sidebar view would be:

    • New event: Create event & Cancel
    • Edit existing single: Save, More options (with "Delete event" and room for future actions like duplicate)
    • Edit existing recurring: Save (opens modal, see Google Cal and Business Calendar on mobile), More options (as above)

Can definitely be polished more, especially for each of the fields, but what do you think?

@ChristophWurst
Copy link
Member Author

Looks great! We can work on this improvement later.

For the short term we'll then need another approach, the redesigned cards won't help us with the room suggestions. After all the design doesn't even contain the option to book a room or resource. The main driver for moving to a modal was #3418 (comment).

@jancborchardt jancborchardt moved this to ☑️ Done in 🖍 Design team Mar 7, 2022
@ChristophWurst ChristophWurst moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Mar 17, 2022
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection labels Mar 17, 2022
@ChristophWurst ChristophWurst added the skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills label Jul 16, 2022
@nekohayo
Copy link

I simply wanted to say here that I'm very happy to see some design work happening on moving towards a cards/overlay/popover design rather than the existing sidebar, because the biggest annoyance I have with the current calendar UI is that it requires opening and closing the sidebar all the time, which has two issues:

  • It's slow. There is noticeable latency to open and load the sidebar, every time.
  • It shifts/squeezes the calendar's view, which is very visually annoying. This may sound silly, but I really can't stand it, the UI bouncing around like a compressed sponge makes it "annoying" to interact with.

I am under the impression that you were not redesigning specifically for this but to solve other issues (with rooms etc.), but I'm mentioning the papercuts above so that those considerations are on your radar if they weren't already.

@ChristophWurst ChristophWurst moved this from 📄 To do (~10 entries) to 🧭 Planning evaluation (dont pick) in 💌 📅 👥 Groupware team Aug 18, 2022
@jancborchardt jancborchardt moved this from 🎉 Done to 🏗️ At engineering in 🖍 Design team Apr 3, 2023
@jancborchardt jancborchardt moved this from 🏗️ At engineering to 🧭 Planning evaluation / ideas in 🖍 Design team Oct 19, 2023
@jancborchardt jancborchardt moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team Dec 21, 2023
@ChristophWurst ChristophWurst moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Dec 21, 2023
@st3iny
Copy link
Member

st3iny commented Jan 9, 2024

Thank you for the detailed mockups :)

I'm starting to implement the improvements and realized that is is not possible to move an event to another calendar. The calendar dot and name is shown at the top of the popover and sidebar editors but I don't see a way to change it.

Did I miss something? Otherwise, I'd appreciate some feedback on how to implement the calendar picker.

cc @nimishavijay

PS: I just saw the "Calendar picker can be a button instead of a dropdown, and clicking on it opens an action menu with the different calendars" item in the post above. A button makes sense but were should it be put?

@st3iny st3iny moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team Jan 9, 2024
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2024
@nimishavijay
Copy link
Member

Did I miss something?

🤔 This is what I mean when I say calendar picker, the calendar that an event is in is changeable right? Currently it looks like this:

image

A button makes sense but were should it be put?

At the top! :) "Personal" is the calendar the event is a part of, and clicking on it opens an action menu with the different calendars that the user has.

image

Did I misunderstand your question? :)

@st3iny
Copy link
Member

st3iny commented Jan 15, 2024

At the top! :) "Personal" is the calendar the event is a part of, and clicking on it opens an action menu with the different calendars that the user has.

That answers my question. Thanks :)

@st3iny
Copy link
Member

st3iny commented Jan 15, 2024

Unfortunately, using text fields with internal labels and icons is not deliverable at the moment. There are multiple reasons:

  1. The NcTextArea component (used for the description) does not support internal icons yet.
  2. We are still on nextcloud/vue 7 but the migration is already in progress: Migrate/to nextcloud vue 8 #5648

The rest of the feedback can be delivered. We can move the conversion of all input fields to a follow-up PR. It can be done once NcTextArea is fixed and we successfully migrated to the required nextcloud/vue version, which should be either 8 or 9.

PS: About NcTextArea: I implemented the component initially and decided to drop the internal icon feature for the time being. It turned out to be very complex and there was no need back then. I'll start working on it again after implementing the redesign.

@nimishavijay
Copy link
Member

@st3iny no worries, in that case for the first version we can just show the icon on the outside, like how it would be in the sidebar :)

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 29, 2024
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 1, 2024
@nimishavijay nimishavijay moved this from 🏗️ At engineering to 🕶️ Design review in 🖍 Design team Feb 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Feb 20, 2024
@szaimen
Copy link
Contributor

szaimen commented Feb 20, 2024

🎉🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants