Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving faces fails with NC28 RC2 #1043

Closed
pstumpe opened this issue Dec 1, 2023 · 5 comments · Fixed by #1044
Closed

Moving faces fails with NC28 RC2 #1043

pstumpe opened this issue Dec 1, 2023 · 5 comments · Fixed by #1044
Labels
bug Something isn't working

Comments

@pstumpe
Copy link

pstumpe commented Dec 1, 2023

Which version of recognize are you using?

6.0.0

Enabled Modes

Object recognition, Face recognition

TensorFlow mode

WASM mode

Downstream App

Memories App

Which Nextcloud version do you have installed?

Nextcloud 28.0.0 RC2

Which Operating system do you have installed?

OmniOS r151046

Which database are you running Nextcloud on?

PostgreSQL 15.3

Which Docker container are you using to run Nextcloud? (if applicable)

No response

How much RAM does your server have?

12GB

What processor Architecture does your CPU have?

amd64 i386

Describe the Bug

When selecting images from the "unassigned faces" page in Memories and selecting a target person the system throws an error message like 'Failed to move IMG_XYZ.jpg from face.'

Expected Behavior

The face would be assigned to the selected person.

To Reproduce

Just try to assign an unrecognized face to a person.

Debug log

[webdav] Fehler: OCA\Recognize\Dav\Faces\FacesHome::__construct(): Argument #6 ($previewManager) must be of type OCP\IPreview, null given, called in /opt/local/share/httpd/htdocs/nextcloud/apps/recognize/lib/Dav/RecognizeHome.php on line 63
	MOVE /nextcloud/remote.php/dav/recognize/user123/unassigned-faces/63470-IMG_ABC.jpg
@pstumpe pstumpe added the bug Something isn't working label Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Hello 👋

Thank you for taking the time to open this issue with recognize. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue
Cheers 💙

@pstumpe
Copy link
Author

pstumpe commented Dec 1, 2023

Found this additional error in the backend preceeding the one above:

{
    "reqId": "XsvJzH1TXEUoPPx9tnrI",
    "level": 3,
    "time": "2023-12-01T09:01:07+00:00",
    "remoteAddr": "192.168.100.62",
    "user": "user123",
    "app": "PHP",
    "method": "MOVE",
    "url": "/nextcloud/remote.php/dav/recognize/user123/unassigned-faces/63470-IMG_ABC.jpg",
    "message": "Undefined variable $metadataManager at /opt/local/share/httpd/htdocs/nextcloud/apps/recognize/lib/Dav/RecognizeHome.php#37",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36",
    "version": "28.0.0.8",
    "data": {
        "app": "PHP"
    },
    "id": "6569a50d51863"
}

@marcelklehr
Copy link
Member

Nice catch! Thank you for testing this! Will fix asap

@pstumpe
Copy link
Author

pstumpe commented Dec 4, 2023

Works like charm with 6.0.1!

@marcelklehr
Copy link
Member

Yay! Thank you for re-testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants