From e709ea5332afbe0eb5c70569793526854b628ddc Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Fri, 30 Aug 2024 10:01:21 +0200 Subject: [PATCH] Revert "fix(TaskProcessing): Use OCP\Server::get instead of copying methods" This reverts commit d624c8da8f0dc2eaf18d416aa15db0a2035de398. --- lib/private/TaskProcessing/Manager.php | 50 +++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/lib/private/TaskProcessing/Manager.php b/lib/private/TaskProcessing/Manager.php index 8a5d64e351ff5..fb0a4da4c4e23 100644 --- a/lib/private/TaskProcessing/Manager.php +++ b/lib/private/TaskProcessing/Manager.php @@ -36,7 +36,6 @@ use OCP\IServerContainer; use OCP\L10N\IFactory; use OCP\Lock\LockedException; -use OCP\SpeechToText\ISpeechToTextManager; use OCP\SpeechToText\ISpeechToTextProvider; use OCP\SpeechToText\ISpeechToTextProviderWithId; use OCP\TaskProcessing\EShapeType; @@ -96,9 +95,31 @@ public function __construct( $this->appData = $appDataFactory->get('core'); } + + /** + * This is almost a copy of textProcessingManager->getProviders + * to avoid a dependency cycle between TextProcessingManager and TaskProcessingManager + */ private function _getRawTextProcessingProviders(): array { - $textProcessingManager = \OCP\Server::get(\OCP\TextProcessing\IManager::class); - return $textProcessingManager->getProviders(); + $context = $this->coordinator->getRegistrationContext(); + if ($context === null) { + return []; + } + + $providers = []; + + foreach ($context->getTextProcessingProviders() as $providerServiceRegistration) { + $class = $providerServiceRegistration->getService(); + try { + $providers[$class] = $this->serverContainer->get($class); + } catch (\Throwable $e) { + $this->logger->error('Failed to load Text processing provider ' . $class, [ + 'exception' => $e, + ]); + } + } + + return $providers; } private function _getTextProcessingProviders(): array { @@ -347,9 +368,28 @@ public function getOptionalOutputShapeEnumValues(): array { return $newProviders; } + /** + * This is almost a copy of SpeechToTextManager->getProviders + * to avoid a dependency cycle between SpeechToTextManager and TaskProcessingManager + */ private function _getRawSpeechToTextProviders(): array { - $speechToTextManager = \OCP\Server::get(ISpeechToTextManager::class); - return $speechToTextManager->getProviders(); + $context = $this->coordinator->getRegistrationContext(); + if ($context === null) { + return []; + } + $providers = []; + foreach ($context->getSpeechToTextProviders() as $providerServiceRegistration) { + $class = $providerServiceRegistration->getService(); + try { + $providers[$class] = $this->serverContainer->get($class); + } catch (NotFoundExceptionInterface|ContainerExceptionInterface|\Throwable $e) { + $this->logger->error('Failed to load SpeechToText provider ' . $class, [ + 'exception' => $e, + ]); + } + } + + return $providers; } /**