Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LDAP user creation on login, not on addition to LDAP #50167

Closed
Justinzobel opened this issue Jan 14, 2025 · 3 comments
Closed

Allow LDAP user creation on login, not on addition to LDAP #50167

Justinzobel opened this issue Jan 14, 2025 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: ldap performance 🚀

Comments

@Justinzobel
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Allow LDAP users to be created in Nextcloud only on their first login, instead of at the point in time where they are added to LDAP.

This would make sense for many organizations as it saves storage space, database space and CPU cycles as I imagine many background tasks touch every single user in the database.

I imagine this process being as follows, the login function checks if the user exists locally, if they do not, they then check if they are a valid LDAP user. If they're a valid LDAP user, they're added at that point to the local Nextcloud database. If this process takes more than one or two seconds, it could present the user with a small loading screen indicating that their user information is being synchronised to Nextcloud.

Describe alternatives you've considered
None

Additional context
None

@Justinzobel Justinzobel added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 14, 2025
@Justinzobel
Copy link
Author

This would improve sustainability in Nextcloud by requiring less resources overall until they're needed by the user.

@joshtrichards
Copy link
Member

joshtrichards commented Jan 15, 2025

Unless I'm mistaken, this is already the case today. (and it's certainly how non-LDAP user creation/logins work).

And I can't find any references to getUserFolder() in the user_ldap app.

Though there may be some edge cases.

Are you just using user_ldap? Anything like user_saml too?

@Justinzobel
Copy link
Author

My apologies, I was mistaken. Thanks for the reply @joshtrichards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: ldap performance 🚀
Projects
None yet
Development

No branches or pull requests

2 participants