Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rename file doesn't exit focus if not renamed #50170

Closed
4 of 8 tasks
solracsf opened this issue Jan 14, 2025 · 5 comments
Closed
4 of 8 tasks

[Bug]: Rename file doesn't exit focus if not renamed #50170

solracsf opened this issue Jan 14, 2025 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. needs info

Comments

@solracsf
Copy link
Member

solracsf commented Jan 14, 2025

⚠️ This issue respects the following points: ⚠️

Bug description

When renaming a fil, if the file name is not changed, field FOCUS is not released. Only way to release it either rename the file, or reload the page.

Steps to reproduce

  1. Try to rename a file on the WebUI, but change your mind and finally, don't change the file name (even if you type something).
  2. Try to press ENTER or exit the reanme field. Nothing happens.

Expected behavior

Focus is releases once press ENTER or clic anywhere on the page

Nextcloud Server version

30

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

@solracsf solracsf added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug 1. to develop Accepted and waiting to be taken care of hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 14, 2025
@susnux
Copy link
Contributor

susnux commented Jan 14, 2025

I can not reproduce this, if I click outside then the renaming is canceled (input field is removed).
If I press enter then the file is renamed and the input field is removed.

@susnux susnux added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 14, 2025
@solracsf

This comment has been minimized.

@solracsf
Copy link
Member Author

Minimal reproduce steps:

  1. Right click on a folder/file
  2. Chose "Rename"
  3. Press ENTER

In my 30.0.4 instance, nothing happens, and focus stay open 🤔

Image

Focus exit if I press ESC

@XueSheng-GIT
Copy link

I can reproduce the issue in NC 30.0.4.

@susnux
Copy link
Contributor

susnux commented Jan 15, 2025

I can reproduce with 30.0.4 but it is fixed with 30.0.5rc1 so will be fixed with the next maintenance release.

@susnux susnux closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. needs info
Projects
None yet
Development

No branches or pull requests

4 participants