From b6ebc977d18b4609647f7606b878526623a8040b Mon Sep 17 00:00:00 2001 From: GreyXor Date: Sat, 19 Oct 2024 02:43:57 +0200 Subject: [PATCH 1/2] fix: add eol in dav command and use success const as return code --- apps/dav/lib/Command/FixCalendarSyncCommand.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/dav/lib/Command/FixCalendarSyncCommand.php b/apps/dav/lib/Command/FixCalendarSyncCommand.php index bb269c92e1526..2611787186f80 100644 --- a/apps/dav/lib/Command/FixCalendarSyncCommand.php +++ b/apps/dav/lib/Command/FixCalendarSyncCommand.php @@ -54,7 +54,8 @@ public function execute(InputInterface $input, OutputInterface $output): int { }); $progress->finish(); } - return 0; + $output->writeln(''); + return self::SUCCESS; } private function fixUserCalendars(IUser $user, ?ProgressBar $progress = null): void { From 089d04e06a937fb7215e7b123f5ae6c5ff4df45b Mon Sep 17 00:00:00 2001 From: GreyXor Date: Wed, 15 Jan 2025 00:22:24 +0100 Subject: [PATCH 2/2] fix: use self failure for consistency --- apps/dav/lib/Command/FixCalendarSyncCommand.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/dav/lib/Command/FixCalendarSyncCommand.php b/apps/dav/lib/Command/FixCalendarSyncCommand.php index 2611787186f80..cb31355c10da1 100644 --- a/apps/dav/lib/Command/FixCalendarSyncCommand.php +++ b/apps/dav/lib/Command/FixCalendarSyncCommand.php @@ -43,7 +43,7 @@ public function execute(InputInterface $input, OutputInterface $output): int { $user = $this->userManager->get($userArg); if ($user === null) { $output->writeln("User $userArg does not exist"); - return 1; + return self::FAILURE; } $this->fixUserCalendars($user);