From 182acb1e299f71623609bde7ebca21f71985befd Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Fri, 10 Jan 2025 18:17:22 +0100 Subject: [PATCH 1/3] fix(template): Use `
` instead of `
` to support Vue3 apps mounting Vue3 does not replace the element while mounting but only renders within (replace inner HTML). So it would result in two stacked `
` elements which is invalid and an accessibility issue. Instead we just use a `
` element for mounting. For Vue2 apps this does not change anything as the whole element will be replaced with a new `
` element. For vanilla apps this will slightly decrease the accessibility as the main landmark is now missing, but this is not a hard accessibility issue as it would be for Vue3 apps having two main elements. Signed-off-by: Ferdinand Thiessen --- core/templates/layout.guest.php | 4 ++-- core/templates/layout.public.php | 5 +++-- core/templates/layout.user.php | 4 ++-- cypress/e2e/theming/a11y-color-contrast.cy.ts | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/core/templates/layout.guest.php b/core/templates/layout.guest.php index f006a6fda3818..64bec6de9be53 100644 --- a/core/templates/layout.guest.php +++ b/core/templates/layout.guest.php @@ -47,12 +47,12 @@
-
+

getName()); ?>

-
+
-
+

getHeaderTitle() !== '') { @@ -90,7 +90,8 @@ } ?>

-
+ + getFooterVisible() && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?>