Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting includes #54

Open
edmundmiller opened this issue Nov 5, 2024 · 2 comments
Open

Sorting includes #54

edmundmiller opened this issue Nov 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@edmundmiller
Copy link

TL;DR would love to sort includes. I typically see them sorted by when the module comes up in the file, but I could see alphabetical like Python files also working.

Just went through some pipeline code and ran the formatter on everything. This is going to be huge for standardizing scripts.

Not sure whether to open issues here or in the vscode extension.

@bentsherman
Copy link
Member

Includes are typically declared in separate groups for different kinds of includes. Do you think the language server should try to preserve these groupings, only sort within those groups? Or just sort everything into a single list?

@edmundmiller
Copy link
Author

I think sorting within groups would be cool for the reasoning you explained!

@bentsherman bentsherman added the enhancement New feature or request label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants