Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track name doesn't update automatically in Places panel #842

Open
bradh opened this issue Jan 22, 2020 · 0 comments · May be fixed by #1116
Open

Track name doesn't update automatically in Places panel #842

bradh opened this issue Jan 22, 2020 · 0 comments · May be fixed by #1116

Comments

@bradh
Copy link
Collaborator

bradh commented Jan 22, 2020

I'm creating Tracks in Places, and updating the names after initial track creation (its from ADS-B, and sometimes a message with the callsign doesn't arrive for a while).

In that case, the label drawn on the track gets updated. However the name shown in the Places panel doesn't get updated.
I can force an update by clicking on the edit (pen icon) to bring up the "Edit Place" dialog (which has the Name field shown correctly - no changes needed), then clicking OK to close that dialog.

I guess I need a listener to check for changes on the Track.
smithtb pushed a commit to smithtb/opensphere that referenced this issue Oct 7, 2020
@wisestmumbler
Merge pull request ngageoint#842 in WV/opensphere from ~JENKINS/opens…
798d160 
…phere:upscanMerge to master

* commit '8342cf86b847bcd36658fe4fc330146d6d18d1ed': (27 commits)
  style(autofill): Apply autofill keyframe for webkit browsers.
  feat(states): Add timeline lock to states
  test(cypress): Removes flags from http-server startup that were not needed
  feat(descriptor): Added the ability to setNodeUI on basedescriptor objects
  fix(search): Search on typeahead result click.
  test(metrics): Additional unit tests for metrics.
  chore(metrics): Remove unused stub AreasMetrics implementation
  fix(ui): Use grab cursor instead of pointer cursor when grabbing
  fix(scss): webkit theme autofill
  fix(kml): Replace the OpenLayers default icon with OpenSphere's.
  fix(settings): Call parent destroy to clean up listeners.
  fix(window): Clean up resize handler and avoid errors if called after dispose.
  test(cypress): Removes exception handling for error that has been fixed in the application
  feat(search): Add generic facets for keying off an item/feature value.
  fix(search): Split original term to avoid regex escape chars.
  refactor(search): Don't require a custom feature config on coord results.
  refactor(search): Extract generic local facet code from descriptor facets.
  fix(scss): fix theme autofill
  style(cypress): Fixes typo
  chore(index): Update opensphere-build-index to use debug loader.
  ...
bradh added a commit to bradh/opensphere that referenced this issue Dec 13, 2020
@bradh
fix(track): ensure places node list will update when track name changes
01c78ed 
Resolves ngageoint#842

The caller updating the track name (or other values) still has to call
track.dispatchEvent(new os.events.PropertyChangeEvent(os.annotation.EventType.UPDATE_PLACEMARK));
@bradh bradh linked a pull request Dec 13, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(track): ensure places node list will update when track name changes bradh/opensphere
1 participant
@bradh