Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the Data Plane with Control Plane #2844

Open
mpstefan opened this issue Nov 27, 2024 · 0 comments
Open

Deploy the Data Plane with Control Plane #2844

mpstefan opened this issue Nov 27, 2024 · 0 comments
Labels
blocked Blocked by other issue enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Nov 27, 2024

As a user of NGF
I want the control plane to deploy the data plane
So that I do not need to manage it's deployment via Helm
And so that data plane instance management is done by the control plane.

Acceptance

  • When a Gateway object is created within the cluster and targets NGF as the implementation, the data plane is deployed with the configuration specified via Gateway API.
  • Data plane deployment and service are configurable with the same fields exposed via Helm via the NginxProxy CRD
    • Only the fields the user specifies in the NginxProxy CRD will be used to update a running data plane deployment.
    • If the NginxProxy is referenced, but is invalid or nonexistent, then default values are used.
  • On startup, the control plane should ensure that any existing nginx deployments/services have the proper configuration
    • This ensures that if the control plane goes down, and any NginxProxy changes occurred during that downtime, that they are applied on restart
    • It also ensures that when the control plane is updated to a new version, we patch and rollout the updated nginx pods.
  • Gateway resource should be able to exist in any namespace, and the nginx deployment is created in that namespace
    • Any bootstrap resources (secrets, configmaps, etc.) also need to be created in that namespace
  • Prometheus metrics endpoint is configured via agent conf, and nginx metrics can be scraped properly by Prometheus
  • Enable GatewayInfrastructurePropagation conformance tests
  • Remove temporary NGINX templates from the Helm chart.

Dev Notes

@mpstefan mpstefan changed the title Control Plane Deploys the Data Plane and Remove Data Plane Helm Deployment (single Gateway support) Deploy the Data Plane with Control Plane Nov 27, 2024
@mpstefan mpstefan added the enhancement New feature or request label Nov 27, 2024
@mpstefan mpstefan added this to the v1.6.0 milestone Nov 27, 2024
@mpstefan mpstefan modified the milestones: v1.6.0, v2.0.0 Jan 6, 2025
@sjberman sjberman added the blocked Blocked by other issue label Jan 8, 2025
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by other issue enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants