From 68e220a0e2c188fb76cc1868142db1aa0eef3a3d Mon Sep 17 00:00:00 2001 From: Jesse Attas Date: Wed, 14 Aug 2024 15:56:42 -0500 Subject: [PATCH] Update lighthouse accessibility minScore back to 0.9 (#2346) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## 🤨 Rationale Resolves #280. Thanks to some recent fixes, the accessibility score for the Angular app is now back above 0.9 (it's 93%). We'd like to prevent regressions by ratcheting the `minScore` back to where it was originally before #1809. ## 👩‍💻 Implementation `0.8` ➡️ `0.9` in angular example app lighthouse config ## 🧪 Testing The Lighthouse step passed in the [main / build (push) PR check](https://github.com/ni/nimble/actions/runs/10394512684/job/28784465522?pr=2346) and the [Lighthouse report looks sane](https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1723668148618-11515.report.html). ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --- packages/angular-workspace/lighthouserc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/angular-workspace/lighthouserc.js b/packages/angular-workspace/lighthouserc.js index d221ad05a9..18ae7f1cc1 100644 --- a/packages/angular-workspace/lighthouserc.js +++ b/packages/angular-workspace/lighthouserc.js @@ -17,7 +17,7 @@ module.exports = { assert: { assertions: { 'categories:performance': ['error', { minScore: 0.8 }], - 'categories:accessibility': ['error', { minScore: 0.8 }] + 'categories:accessibility': ['error', { minScore: 0.9 }] } }, upload: {