From bfa3e3683f6e2e8a2ec6807fcdde7f15ae265a3a Mon Sep 17 00:00:00 2001 From: m-akinc <7282195+m-akinc@users.noreply.github.com> Date: Tue, 8 Oct 2024 12:23:46 -0500 Subject: [PATCH] Disable intermittent test (#2427) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## ๐Ÿคจ Rationale Test failed on unrelated PR build. ## ๐Ÿ‘ฉโ€๐Ÿ’ป Implementation Skipping test on Webkit (can disable fully if it later fails on another browser). Filed #2426 to track it. ## ๐Ÿงช Testing N/A --------- Co-authored-by: Milan Raj --- ...le-components-b21543ab-0fd2-4721-a028-5ba754ec52c2.json | 7 +++++++ .../src/rich-text/models/tests/markdown-serializer.spec.ts | 3 ++- packages/storybook/.storybook/preview.js | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 change/@ni-nimble-components-b21543ab-0fd2-4721-a028-5ba754ec52c2.json diff --git a/change/@ni-nimble-components-b21543ab-0fd2-4721-a028-5ba754ec52c2.json b/change/@ni-nimble-components-b21543ab-0fd2-4721-a028-5ba754ec52c2.json new file mode 100644 index 0000000000..c3697a489c --- /dev/null +++ b/change/@ni-nimble-components-b21543ab-0fd2-4721-a028-5ba754ec52c2.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Disable intermittent test", + "packageName": "@ni/nimble-components", + "email": "7282195+m-akinc@users.noreply.github.com", + "dependentChangeType": "none" +} diff --git a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts index e32469d4d8..2e06cfb9f1 100644 --- a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts +++ b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts @@ -358,7 +358,8 @@ Plain text 3`); expect(element.getMarkdown()).toEqual(' '); }); - it('Multiple Mention node of different type', async () => { + // Intermittent on Webkit (at least), see https://github.com/ni/nimble/issues/2426 + it('Multiple Mention node of different type #SkipWebkit', async () => { await appendUserMentionConfiguration(element, [ { key: 'user:1', displayName: 'username1' } ]); diff --git a/packages/storybook/.storybook/preview.js b/packages/storybook/.storybook/preview.js index e5fd5a9ee7..9572216033 100644 --- a/packages/storybook/.storybook/preview.js +++ b/packages/storybook/.storybook/preview.js @@ -105,5 +105,5 @@ configureActions({ depth: 1 }); -// Update the GUID on this line to trigger a turbosnap full rebuild: 9236157e-5f33-411d-aede-26045b7d9d58 +// Update the GUID on this line to trigger a turbosnap full rebuild: acea85eb-3c9d-49c3-ae4f-7c12f82bc5a0 // See https://www.chromatic.com/docs/turbosnap/#full-rebuilds