Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff bot should warn if VIs are included in a pull request but no changes have been made #37

Open
rtzoeller opened this issue Mar 14, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@rtzoeller
Copy link
Contributor

It is easy to unintentionally save a VI without changes, or make a change to a VI and then undo it while re-saving. Since it can be difficult to diff VIs locally without additional setup, these changes tend to sneak into pull requests.

The diff bot (and underlying diff tools) could be modified to report back when a VI does not have any changes, and this information could be bubbled up to the pull request explicitly, instead of requiring the reviewer to check the diffs manually.

@rtzoeller rtzoeller added the enhancement New feature or request label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant