Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path pickling for gbasf2 fails for conditional paths, e.g. udst.add_skimmed_udst_output #182

Open
meliache opened this issue Jan 13, 2023 · 1 comment
Labels
bug Something isn't working gbasf2 Concerns the gbasf2/grid b2luigi wrapper help wanted Extra attention is needed

Comments

@meliache
Copy link
Collaborator

meliache commented Jan 13, 2023

Originally posted by @schmitca in #181 (comment):

Dear @meliache, I am happy to test it. At the moment, the grid jobs with udst.root output fail, before download can be attempted. This is because running the pickled basf2 path with udst.add_skimmed_udst_output(skimDecayMode='skimname') fails with

[FATAL] identical from/to parameter value   { module: SwitchDataStore ('' -> 'skim_skimname') function: virtual void Belle2::SwitchDataStoreModule::initialize() }
[INFO] ===Error Summary================================================================
[FATAL] identical from/to parameter value   { module: SwitchDataStore ('' -> 'skim_skimname') }

This can be traced back to the fact that
basf2.pickle_path.deserialize_path( basf2.pickle_path.serialize_path(mypath)) != mypath
I will try to find/contact an expert for basf2.pickle_path.

Originally posted by @meliache in #181 (comment):

I just checked the definition of udst.add_skimmed_udst_output and it seems that it creates an additional conditional path

    skim_path = basf2.create_path()
    [...]
    filter_path.add_independent_path(skim_path, "skim_" + skimDecayMode)
    add_udst_output(
        skim_path,
        outputFile,
        saveParticleLists,
        additionalBranches,
        dataDescription=dataDescription,
        mc=mc,
    )

I don't understand conditional paths super well, but it's well possible that serialize_path has problems with that.

basf2.pickle_path.deserialize_path( basf2.pickle_path.serialize_path(mypath)) != mypath
You could check really what's the difference by eye or looking at the diff of basf2.print_path. Sadly I don't think I have the time to dig into thhat.

@meliache meliache added bug Something isn't working help wanted Extra attention is needed gbasf2 Concerns the gbasf2/grid b2luigi wrapper labels Jan 13, 2023
@schmitca
Copy link
Contributor

Thank you @meliache for opening this. I issued a JIRA ticket for basf2 with more info:
https://agira.desy.de/browse/BIIANA-313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gbasf2 Concerns the gbasf2/grid b2luigi wrapper help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants