Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafra support #5

Open
2 of 13 tasks
nmeylan opened this issue Aug 11, 2022 · 2 comments
Open
2 of 13 tasks

Add kafra support #5

nmeylan opened this issue Aug 11, 2022 · 2 comments

Comments

@nmeylan
Copy link
Owner

nmeylan commented Aug 11, 2022

In order to add kafra script work, following native function should be implemented:

  • cutin
  • percentheal
  • viewpoint
  • implode
  • countitem
  • delitem
  • basicskillcheck
  • getskilllv
  • getcharid
  • getguildinfo
  • savepoint
  • emotion
  • logmes
@danielhe4rt
Copy link
Contributor

Hey! I dig in into the scripting system and so far that's what I understood:


if you want to contribute with the npc scripting, follow the instructions below

  • add the new function into ./native_functions_list.txt and make sure about the return type setted
  • create your test npc call at config/npc/pre-re/custom/test.txt with the new function to be coded
  • add the new function at server/src/server/script/mod.rs under the NativeMethodHandler (line 180~)
  • IF there's any constant defined on the rAthena e/or Hercules scripting, add it on server/src/server/script/constant.rs

The goal is to make scripting compatible with rAthena and Hercules, so use their source and study how they implemented the function.


That's correct or I'm missing something?

@nmeylan
Copy link
Owner Author

nmeylan commented Dec 16, 2023

yes that is it.
We need to implement missing function as they are described in doc https://github.com/rathena/rathena/blob/master/doc/script_commands.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants