Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Major code cleanup #20

Open
1 of 3 tasks
noah1510 opened this issue Jan 29, 2020 · 2 comments
Open
1 of 3 tasks

Major code cleanup #20

noah1510 opened this issue Jan 29, 2020 · 2 comments
Assignees
@noah1510
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.0.0

Comments

@noah1510
Copy link
Owner

noah1510 commented Jan 29, 2020 •
edited
Loading

At the moment the code is not really taking advantage of a lot of c++11 and newer features.
Before the public release at least all pointers going in and out of the engine should be smart pointer (shared or unique pointers).

The following things have to be implemented before releasing version 0.1.0:

  • use rValues as function returns (createRecktangle, createCircle)
  • removing copy constructors
  • if object shader is nullptr use default shader
@noah1510 noah1510 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 29, 2020
@noah1510 noah1510 added this to the going public milestone Jan 29, 2020
@noah1510 noah1510 self-assigned this Feb 13, 2020
noah1510 added a commit that referenced this issue Feb 13, 2020
@noah1510
added version number and version string #20
dd3dabe
noah1510 added a commit that referenced this issue Feb 14, 2020
@noah1510
cleaned ip engine and world #20
2f1c738
noah1510 added a commit that referenced this issue Feb 14, 2020
@noah1510
small imporvements to gameobject #20
b3f2002
noah1510 added a commit that referenced this issue Feb 17, 2020
@noah1510
putting everything in one namespace #24 #20
7d0df88
noah1510 added a commit that referenced this issue Feb 17, 2020
@noah1510
merging dev-noa to master (#25)
606052f 
* started modernizing pointers

* fixed an issued caused by an shared pointer

* added version number and version string #20

* cleaned ip engine and world #20

* small imporvements  to gameobject #20

* the engine will now be compiled as a library #24

* small change to allow ci to compile testgame

* corrected library name for windows

* putting everything in one namespace #24 #20

* fully removing sfml and initial audio source

* ci changes and first version of automatic release

* edit of autorelease

* fully removed sfml and improvements to autodeploy

* forgotten changes from last commit

* more changes to get autobuilds ready

* more ci changes

* changes to dev build and automatic stable build

* fixing name of the testgame

* even more changes to automatic build

* creating a new dev build only on master
noah1510 added a commit that referenced this issue Feb 21, 2020
@noah1510
now using shared pointer on shader #20
5893cf2
@noah1510
Copy link
Owner Author

noah1510 commented Feb 21, 2020 •
edited
Loading

basically all pointers have to be turned into shared pointers

noah1510 added a commit that referenced this issue Feb 29, 2020
@noah1510
final version of shader class for public release (#26)
28a537c 
* started rework of shader

* ci skip updated configurations

* scripts are now faster than ever

* now using shared pointer on shader #20

* now returning 0 if the world changed

* enable all warnings

* removed names for unused parameters

* removed some unneccessary dependencies

* final version of shader class till public release

* fixed most copiler warnings

* small changes and better mutex locking

* added a destructor to shader to delete program

* now using const & to catch to stop warning
@noah1510 noah1510 modified the milestones: going public, v0.1.0 Jun 29, 2020
@noah1510
Copy link
Owner Author

updated missing things for version 0.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@noah1510 noah1510

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@noah1510