Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle application errors more gracefully #73

Open
MattF-NSIDC opened this issue Jul 31, 2023 · 2 comments · May be fixed by #132
Open

Handle application errors more gracefully #73

MattF-NSIDC opened this issue Jul 31, 2023 · 2 comments · May be fixed by #132
Labels
enhancement New feature or request impact/ui Impacts the the user interface
Milestone
4- Improve user m...

Comments

@MattF-NSIDC
Copy link

MattF-NSIDC commented Jul 31, 2023 •
edited
Loading

In dev (FLASK_DEBUG=true), showing a traceback is good. If we are not in dev, we currently show a 500 internal server error page.

To do better than that, we should show something to the user that is useful for reporting the error ("who do I call?"), describes how to recover, and enables them to continue using the app.

We should set this up so all exceptions generated by requests are caught. Does Flask have a built-in method to intercept request exceptions?

Probably a medium-term thing?
@MattF-NSIDC MattF-NSIDC added enhancement New feature or request impact/ui Impacts the the user interface labels Jul 31, 2023
@rmarow
Copy link
Contributor

rmarow commented Aug 21, 2023

https://flask.palletsprojects.com/en/2.3.x/errorhandling/

@rmarow rmarow moved this from Todo to In Progress in US AON Benefit Tool Sep 7, 2023
@rmarow rmarow linked a pull request Sep 7, 2023 that will close this issue
Draft
@mfisher87 mfisher87 moved this from In Progress to Todo in US AON Benefit Tool Dec 18, 2023
@mfisher87
Copy link
Contributor

mfisher87 commented Mar 13, 2024 •
edited
Loading

TODO: We need to figure out how to handle errors with HTMX. E.g. when you delete a node from the node library, it will fail if that node is used in an assessment. It won't tell you why, the button just does nothing. How can we get the server-side error message (e.g. "Can't delete because this node is associated with surveys X, Y, Z") back into the app for the user to see?

Probably by returning some HTML and headers that tell HTMX to populate some reserved space with an error message?

And for the future user experience, what do we suggest as a remedy for the user? E.g. "If you want to hide the node from the library, archive it instead."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request impact/ui Impacts the the user interface
Projects
US AON Benefit Tool
Status: Todo
Milestone
4- Improve user messaging for errors ...
Development

Successfully merging a pull request may close this issue.

[WIP] Error handling mfisher87/usaon-vta-survey
3 participants
@mfisher87 @MattF-NSIDC @rmarow